From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/4] btrfs: convert enum btrfs_compression_type to define
Date: Thu, 17 Aug 2017 04:33:41 +0800 [thread overview]
Message-ID: <6117a0fa-b540-c31f-af10-805fce5b7cfc@oracle.com> (raw)
In-Reply-To: <20170816135941.GE2866@twin.jikos.cz>
On 08/16/2017 09:59 PM, David Sterba wrote:
> On Sun, Aug 13, 2017 at 12:02:42PM +0800, Anand Jain wrote:
>> There isn't a huge list to manage the types, which can be managed
>> with defines. It helps to easily print the types in tracing as well.
>
> We use enums in a lot of places, I'd rather keep it as it is.
This patch converts all of them, and it was at only one place.
I hope I didn't miss any. Further the next patch 3/4 needs it
to be define instead of enums, handling enums in the tracing
isn't as easy as define.
Thanks, Anand
next prev parent reply other threads:[~2017-08-16 20:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-13 4:02 [PATCH 0/4] misc compression tracing related patches Anand Jain
2017-08-13 4:02 ` [PATCH 1/4] btrfs: remove unused BTRFS_COMPRESS_LAST Anand Jain
2017-08-16 13:57 ` David Sterba
2017-08-13 4:02 ` [PATCH 2/4] btrfs: convert enum btrfs_compression_type to define Anand Jain
2017-08-16 13:59 ` David Sterba
2017-08-16 20:33 ` Anand Jain [this message]
2017-08-17 11:57 ` David Sterba
2017-08-30 14:38 ` Anand Jain
2017-09-07 18:52 ` David Sterba
2017-08-13 4:02 ` [PATCH 3/4] btrfs: decode compress type for tracing Anand Jain
2017-08-16 14:03 ` David Sterba
2017-08-13 4:02 ` [PATCH 4/4 v3] btrfs: add compression trace points Anand Jain
2017-08-15 21:09 ` kbuild test robot
2017-08-16 14:38 ` David Sterba
2017-08-16 21:24 ` [PATCH 4/4 v4] " Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6117a0fa-b540-c31f-af10-805fce5b7cfc@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).