From: Anand Jain <anand.jain@oracle.com>
To: "dsterba@suse.cz" <dsterba@suse.cz>
Cc: "Gu, Jinxiang" <gujx@cn.fujitsu.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v5 2/2] btrfs: get device pointer from btrfs_scan_one_device
Date: Tue, 17 Jul 2018 12:54:00 +0800 [thread overview]
Message-ID: <61d50b9c-9230-c841-7d07-8b47799c34c8@oracle.com> (raw)
In-Reply-To: <516DDBE5B1D92D42BCF7A2E37F045A5D01A8A35A22@G08CNEXMBPEKD02.g08.fujitsu.local>
::
>>> @@ -1561,12 +1564,15 @@ static struct dentry *btrfs_mount_root(struct file_system_type *fs_type,
>>> goto error_fs_info;
>>> }
>>>
>>> - error = btrfs_scan_one_device(device_name, mode, fs_type, &fs_devices);
>>> - if (error) {
>>> + device = btrfs_scan_one_device(device_name, mode, fs_type);
>>> + if (IS_ERR(device)) {
>>> + error = PTR_ERR(device);
>>> mutex_unlock(&uuid_mutex);
>>> goto error_fs_info;
>>> }
>>>
>>> + fs_devices = device->fs_devices;
>>> +
The version at misc-next is missing this assignment and it panics.
::
Thanks, Anand
next prev parent reply other threads:[~2018-07-17 5:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 9:34 [PATCH v5 0/2] btrfs: do some parameters optimization Gu Jinxiang
2018-07-16 9:11 ` [PATCH v5 1/2] btrfs: make fs_devices to be a local variable Gu Jinxiang
2018-07-16 12:31 ` Nikolay Borisov
2018-07-16 9:11 ` [PATCH v5 2/2] btrfs: get device pointer from btrfs_scan_one_device Gu Jinxiang
2018-07-16 12:34 ` David Sterba
2018-07-17 1:08 ` Gu, Jinxiang
2018-07-17 4:54 ` Anand Jain [this message]
2018-07-17 13:50 ` David Sterba
2018-07-17 13:48 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61d50b9c-9230-c841-7d07-8b47799c34c8@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=gujx@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).