Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Cc: jirislaby@kernel.org
Subject: Re: [PATCH 0/5] Remove some unused struct members
Date: Tue, 21 Nov 2023 14:20:22 +1030	[thread overview]
Message-ID: <61fa9fda-8dee-4ff1-bbbb-2db3e409c64a@gmx.com> (raw)
In-Reply-To: <cover.1700531088.git.dsterba@suse.com>



On 2023/11/21 12:20, David Sterba wrote:
> Jiri Slaby wrote a tool to find unused struct members [1]. There are
> some interesting fossils. Comparing that to my hacky coccinelle scripts,
> it did a much better job.

Reviewed-by: Qu Wenruo <wqu@suse.com>

>
> [1] https://github.com/jirislaby/clang-struct

The tool looks awesome!

Thanks,
Qu
>
> David Sterba (5):
>    btrfs: scrub: remove unused scrub_ctx::sectors_per_bio
>    btrfs: remove unused btrfs_ordered_extent::outstanding_isize
>    btrfs: raid56: remove unused btrfs_plug_cb::work
>    btrfs: remove unused definition of tree_entry in extent-io-tree.c
>    btrfs: remove unused btrfs_root::type
>
>   fs/btrfs/ctree.h          | 2 --
>   fs/btrfs/extent-io-tree.c | 6 ------
>   fs/btrfs/ordered-data.h   | 7 -------
>   fs/btrfs/raid56.c         | 1 -
>   fs/btrfs/scrub.c          | 1 -
>   5 files changed, 17 deletions(-)
>

  parent reply	other threads:[~2023-11-21  3:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21  1:50 [PATCH 0/5] Remove some unused struct members David Sterba
2023-11-21  1:50 ` [PATCH 1/5] btrfs: scrub: remove unused scrub_ctx::sectors_per_bio David Sterba
2023-11-21  1:50 ` [PATCH 2/5] btrfs: remove unused btrfs_ordered_extent::outstanding_isize David Sterba
2023-11-21  1:50 ` [PATCH 3/5] btrfs: raid56: remove unused btrfs_plug_cb::work David Sterba
2023-11-21  1:50 ` [PATCH 4/5] btrfs: remove unused definition of tree_entry in extent-io-tree.c David Sterba
2023-11-21  1:50 ` [PATCH 5/5] btrfs: remove unused btrfs_root::type David Sterba
2023-11-21  3:50 ` Qu Wenruo [this message]
2023-11-21  4:31 ` [PATCH 0/5] Remove some unused struct members Anand Jain
2023-11-21  8:45 ` Johannes Thumshirn
2023-11-21 13:05 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61fa9fda-8dee-4ff1-bbbb-2db3e409c64a@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=dsterba@suse.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox