Re: [PATCH v2] btrfs: make btrfs module init/exit match their sequence

[Anand Jain <anand.jain@oracle.com>]

> With this patch, init_btrfs_fs()/exit_btrfs_fs() will be much easier to
> expand and will always follow the strict order.
> 

Nice idea.


>   
> -	btrfs_print_mod_info();
::
>   
> -	err = btrfs_run_sanity_tests();

::

> +	}, {
> +		.init_func = btrfs_run_sanity_tests,
> +		.exit_func = NULL,
> +	}, {
> +		.init_func = btrfs_print_mod_info,
> +		.exit_func = NULL,
> +	}, {


  Is there any special reason to switch the order of calling for 
sanity_tests() and mod_info()?


> +static bool mod_init_result[ARRAY_SIZE(mod_init_seq)];

  Why not move bool mod_init_result into the (non-const) struct 
init_sequence?

> +	/*
> +	 * If we call exit_btrfs_fs() it would cause section mismatch.
> +	 * As init_btrfs_fs() belongs to .init.text, while exit_btrfs_fs()
> +	 * belongs to .exit.text.
> +	 */
  Why not move it into a helper that can be called at both exit and init?

-Anand