linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs: add balance args info during start and resume
Date: Wed, 16 May 2018 10:51:05 +0800	[thread overview]
Message-ID: <653cffe1-3d20-308c-953f-5ae0492f71a3@oracle.com> (raw)
In-Reply-To: <16571dc5-de44-fe74-5641-e825af114cee@oracle.com>


  All comments accepted in v2 in ml, except for the one below.

>>>       clear_bit(BTRFS_FS_BALANCE_RUNNING, &fs_info->flags);
>>>       if (bargs) {
>>> @@ -3947,10 +4096,8 @@ static int balance_kthread(void *data)
>>>       int ret = 0;
>>>       mutex_lock(&fs_info->balance_mutex);
>>> -    if (fs_info->balance_ctl) {
>>> -        btrfs_info(fs_info, "balance: resuming");
>>> +    if (fs_info->balance_ctl)
>>>           ret = btrfs_balance(fs_info->balance_ctl, NULL);
>>> -    }
>> Unrelated change.
> 
>   Why?

  I believe this change is related to this patch, as this patch has
  added the resume log at btrfs_balance() and so we don't needed
  the resume log again in btrfs_kthread().
  OR.
  I don't know your reasoning. I am ignoring this comment as of now.

  V2 is in the ML.

Thanks, Anand

      reply	other threads:[~2018-05-16  2:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26  8:01 [PATCH 0/2] improve balance logs Anand Jain
2018-04-26  8:01 ` [PATCH 1/2] btrfs: improve balance kernel logs Anand Jain
2018-04-26 14:51   ` Nikolay Borisov
2018-04-27  1:33     ` Anand Jain
2018-04-26  8:01 ` [PATCH 2/2] btrfs: add balance args info during start and resume Anand Jain
2018-04-26 21:32   ` Adam Borowski
2018-04-27  6:46   ` Nikolay Borisov
2018-04-28  2:46     ` Anand Jain
2018-05-16  2:51       ` Anand Jain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=653cffe1-3d20-308c-953f-5ae0492f71a3@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nborisov@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).