From: Martin Steigerwald <martin@lichtvoll.de>
To: linux-btrfs@vger.kernel.org, Qu Wenruo <wqu@suse.com>
Subject: Re: [PATCH 0/5] btrfs: scrub: improve the scrub performance
Date: Fri, 28 Jul 2023 14:38:35 +0200 [thread overview]
Message-ID: <6543972.G0QQBjFxQf@lichtvoll.de> (raw)
In-Reply-To: <cover.1690542141.git.wqu@suse.com>
Qu Wenruo - 28.07.23, 13:14:03 CEST:
> The first 3 patches would greately improve the scrub read performance,
> but unfortunately it's still not as fast as the pre-6.4 kernels.
> (2.2GiB/s vs 3.0GiB/s), but still much better than 6.4 kernels
> (2.2GiB vs 1.0GiB/s).
Thanks for the patch set.
What is the reason for not going back to the performance of the pre-6.4
kernel? Isn't it possible with the new scrubbing method? In that case
what improvements does the new scrubbing code have that warrant to have
a lower performance?
Just like to understand the background of this a bit more. I do not mind
a bit lower performance too much, especially in case it is outweighed by
other benefits.
--
Martin
next prev parent reply other threads:[~2023-07-28 12:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 11:14 [PATCH 0/5] btrfs: scrub: improve the scrub performance Qu Wenruo
2023-07-28 11:14 ` [PATCH 1/5] btrfs: scrub: avoid unnecessary extent tree search preparing stripes Qu Wenruo
2023-07-28 11:14 ` [PATCH 2/5] btrfs: scrub: avoid unnecessary csum " Qu Wenruo
2023-07-28 11:14 ` [PATCH 3/5] btrfs: scrub: fix grouping of read IO Qu Wenruo
2023-07-28 11:14 ` [PATCH 4/5] btrfs: scrub: don't go ordered workqueue for dev-replace Qu Wenruo
2023-07-28 11:14 ` [PATCH 5/5] btrfs: scrub: move write back of repaired sectors into scrub_stripe_read_repair_worker() Qu Wenruo
2023-07-28 12:38 ` Martin Steigerwald [this message]
2023-07-28 16:50 ` [PATCH 0/5] btrfs: scrub: improve the scrub performance David Sterba
2023-07-28 21:14 ` Martin Steigerwald
2023-08-01 20:14 ` Jani Partanen
2023-08-01 22:06 ` Qu Wenruo
2023-08-01 23:48 ` Jani Partanen
2023-08-02 1:56 ` Qu Wenruo
2023-08-02 2:15 ` Jani Partanen
2023-08-02 2:20 ` Qu Wenruo
2023-08-03 6:30 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6543972.G0QQBjFxQf@lichtvoll.de \
--to=martin@lichtvoll.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox