From: Nikolay Borisov <nborisov@suse.com>
To: Liu Bo <bo.liu@linux.alibaba.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: assert page dirty bit
Date: Wed, 12 Sep 2018 09:38:49 +0300 [thread overview]
Message-ID: <65915dec-83d5-d79b-c848-d1f4efce8bb8@suse.com> (raw)
In-Reply-To: <1536703587-94565-2-git-send-email-bo.liu@linux.alibaba.com>
On 12.09.2018 01:06, Liu Bo wrote:
> Just in case that someone breaks the rule that pages are dirty as long
> as eb is dirty.
>
> Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
> ---
> fs/btrfs/extent_io.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index fb2bf50134a1..99895f196ecb 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -5184,6 +5184,11 @@ bool set_extent_buffer_dirty(struct extent_buffer *eb)
> set_page_dirty(eb->pages[i]);
> }
>
> +#ifdef BTRFS_DEBUG
And this will never be compiled since the actual ifdef name is
"CONFIG_BTRFS_DEBUG"
> + for (i = 0; i < num_pages; i++)
> + ASSERT(PageDirty(eb->pages[i]));
> +#endif
> +
> return was_dirty;
> }
>
>
next prev parent reply other threads:[~2018-09-12 11:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 22:06 [PATCH] Btrfs: assert page dirty bit Liu Bo
2018-09-12 6:38 ` Nikolay Borisov [this message]
2018-09-12 19:28 ` Liu Bo
2018-09-13 17:46 ` [PATCH v2] " Liu Bo
2018-09-14 6:24 ` Nikolay Borisov
2018-09-14 12:55 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65915dec-83d5-d79b-c848-d1f4efce8bb8@suse.com \
--to=nborisov@suse.com \
--cc=bo.liu@linux.alibaba.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).