From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f68.google.com ([209.85.214.68]:35845 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624AbeEUOUC (ORCPT ); Mon, 21 May 2018 10:20:02 -0400 Received: by mail-it0-f68.google.com with SMTP id e20-v6so21282265itc.1 for ; Mon, 21 May 2018 07:20:01 -0700 (PDT) Subject: Re: [PATCH 00/13] convert block layer to bioset_init()/mempool_init() To: Mike Snitzer , Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, hch@infradead.org, colyli@suse.de, darrick.wong@oracle.com, clm@fb.com, bacik@fb.com, linux-xfs@vger.kernel.org, drbd-dev@lists.linbit.com, linux-btrfs@vger.kernel.org, linux-raid@vger.kernel.org, neilb@suse.com References: <20180520222558.7053-1-kent.overstreet@gmail.com> <20180521140348.GA19069@redhat.com> From: Jens Axboe Message-ID: <686d7df6-c7d1-48a6-b7ff-48dc8aff6a62@kernel.dk> Date: Mon, 21 May 2018 08:19:58 -0600 MIME-Version: 1.0 In-Reply-To: <20180521140348.GA19069@redhat.com> Content-Type: text/plain; charset=utf-8 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 5/21/18 8:03 AM, Mike Snitzer wrote: > On Sun, May 20 2018 at 6:25pm -0400, > Kent Overstreet wrote: > >> Jens - this series does the rest of the conversions that Christoph wanted, and >> drops bioset_create(). >> >> Only lightly tested, but the changes are pretty mechanical. Based on your >> for-next tree. > > By switching 'mempool_t *' to 'mempool_t' and 'bio_set *' to 'bio_set' > you've altered the alignment of members in data structures. So I'll > need to audit all the data structures you've modified in DM. > > Could we get the backstory on _why_ you're making this change? > Would go a long way to helping me appreciate why this is a good use of > anyone's time. Yeah, it's in the first series, it gets rid of a pointer indirection. -- Jens Axboe