linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>
Subject: [PATCH 5/5] btrfs: sysfs: export the force_dev_flush flag
Date: Thu, 15 Jun 2017 18:49:32 +0200	[thread overview]
Message-ID: <6957a4896cc64a1ff44b712bb6723ada016d76b9.1497544265.git.dsterba@suse.com> (raw)
In-Reply-To: <cover.1497544265.git.dsterba@suse.com>

Add per-filesystem tunable to switch on/off the device barriers,
regardless of the actual device support. This is a debugging feature.

The path to the sysfs file is /sys/fs/btrfs/UUID/force_dev_flush,
allowed values are 0 and 1. Default is 0.

Signed-off-by: David Sterba <dsterba@suse.com>
---
 fs/btrfs/sysfs.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index c2d5f3580b4c..197d43911936 100644
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -487,12 +487,59 @@ static ssize_t quota_override_store(struct kobject *kobj,
 
 BTRFS_ATTR_RW(quota_override, quota_override_show, quota_override_store);
 
+static ssize_t force_dev_flush_show(struct kobject *kobj,
+				   struct kobj_attribute *a, char *buf)
+{
+	struct btrfs_fs_info *fs_info = to_fs_info(kobj);
+	int force;
+
+	if (!fs_info)
+		return -EPERM;
+
+	force = !!(test_bit(BTRFS_FS_FORCE_DEV_FLUSH, &fs_info->flags));
+	return snprintf(buf, PAGE_SIZE, "%d\n", force);
+}
+
+static ssize_t force_dev_flush_store(struct kobject *kobj,
+				    struct kobj_attribute *a,
+				    const char *buf, size_t len)
+{
+	struct btrfs_fs_info *fs_info = to_fs_info(kobj);
+	unsigned long force;
+	int err;
+
+	if (!fs_info)
+		return -EPERM;
+
+	if (!capable(CAP_SYS_ADMIN))
+		return -EPERM;
+
+	err = kstrtoul(buf, 10, &force);
+	if (err)
+		return err;
+	if (force > 1)
+		return -EINVAL;
+
+	if (force) {
+		set_bit(BTRFS_FS_FORCE_DEV_FLUSH, &fs_info->flags);
+		btrfs_info(fs_info, "Forced device flushes enabled");
+	} else {
+		clear_bit(BTRFS_FS_FORCE_DEV_FLUSH, &fs_info->flags);
+		btrfs_info(fs_info, "Forced device flushes disabled");
+	}
+
+	return len;
+}
+
+BTRFS_ATTR_RW(force_dev_flush, force_dev_flush_show, force_dev_flush_store);
+
 static const struct attribute *btrfs_attrs[] = {
 	BTRFS_ATTR_PTR(label),
 	BTRFS_ATTR_PTR(nodesize),
 	BTRFS_ATTR_PTR(sectorsize),
 	BTRFS_ATTR_PTR(clone_alignment),
 	BTRFS_ATTR_PTR(quota_override),
+	BTRFS_ATTR_PTR(force_dev_flush),
 	NULL,
 };
 
-- 
2.13.0


  parent reply	other threads:[~2017-06-15 16:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15 16:49 [PATCH 0/5] Preallocate flush bio, sysfs tunable David Sterba
2017-06-15 16:49 ` [PATCH 1/5] btrfs: preallocate device flush bio David Sterba
2017-06-15 21:53   ` Anand Jain
2017-06-16 13:17     ` David Sterba
2017-06-15 16:49 ` [PATCH 2/5] btrfs: account as waiting for IO, while waiting fot the flush bio completion David Sterba
2017-06-15 16:49 ` [PATCH 3/5] btrfs: move dev stats accounting out of wait_dev_flush David Sterba
2017-06-15 22:00   ` Anand Jain
2017-06-15 16:49 ` [PATCH 4/5] btrfs: add fs flag to force device flushing David Sterba
2017-06-15 22:08   ` Anand Jain
2017-06-15 22:27     ` Anand Jain
2017-06-16 14:03       ` David Sterba
2017-06-15 16:49 ` David Sterba [this message]
2017-06-15 22:24   ` [PATCH 5/5] btrfs: sysfs: export the force_dev_flush flag Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6957a4896cc64a1ff44b712bb6723ada016d76b9.1497544265.git.dsterba@suse.com \
    --to=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).