From: Nikolay Borisov <nborisov@suse.com>
To: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/3] Coldify, constify, purify (function attributes)
Date: Wed, 2 Oct 2019 15:20:50 +0300 [thread overview]
Message-ID: <69cb3c55-78ec-2060-c5a5-d238efef1206@suse.com> (raw)
In-Reply-To: <cover.1569587835.git.dsterba@suse.com>
On 1.10.19 г. 20:57 ч., David Sterba wrote:
> There's a gcc option -Wsuggest-attribute that, as it says, suggests some
> function attributes to provide some hints and allowing more
> optimizations.
>
> Debug build
>
> text data bss dec hex filename
> 1514058 146768 27496 1688322 19c302 pre/btrfs.ko
> 1512603 146736 27496 1686835 19bd33 post/btrfs.ko
> DELTA: -1455
>
> Release build
>
> text data bss dec hex filename
> 1079288 17316 14912 1111516 10f5dc pre/btrfs.ko
> 1078138 17316 14912 1110366 10f15e post/btrfs.ko
> DELTA: -1150
>
> David Sterba (3):
> btrfs: add __cold attribute to more functions
> btrfs: add const function attribute
> btrfs: add __pure attribute to functions
Checking up the with compiler ppl and discussing I can say:
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
>
> fs/btrfs/async-thread.c | 6 ++----
> fs/btrfs/async-thread.h | 4 ++--
> fs/btrfs/ctree.c | 2 +-
> fs/btrfs/ctree.h | 6 +++---
> fs/btrfs/dev-replace.c | 2 +-
> fs/btrfs/dev-replace.h | 2 +-
> fs/btrfs/disk-io.c | 4 ++--
> fs/btrfs/disk-io.h | 4 ++--
> fs/btrfs/ioctl.c | 2 +-
> fs/btrfs/space-info.c | 2 +-
> fs/btrfs/space-info.h | 2 +-
> fs/btrfs/super.c | 4 ++--
> fs/btrfs/volumes.c | 4 ++--
> fs/btrfs/volumes.h | 2 +-
> 14 files changed, 22 insertions(+), 24 deletions(-)
>
prev parent reply other threads:[~2019-10-02 12:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 17:57 [PATCH 0/3] Coldify, constify, purify (function attributes) David Sterba
2019-10-01 17:57 ` [PATCH 1/3] btrfs: add __cold attribute to more functions David Sterba
2019-10-02 10:52 ` Nikolay Borisov
2019-10-04 10:56 ` David Sterba
2019-10-01 17:57 ` [PATCH 2/3] btrfs: add const function attribute David Sterba
2019-10-02 11:07 ` Nikolay Borisov
2019-10-04 11:01 ` David Sterba
2019-10-01 17:57 ` [PATCH 3/3] btrfs: add __pure attribute to functions David Sterba
2019-10-02 11:09 ` Nikolay Borisov
2019-10-01 17:57 ` [PATCH 0/3] Coldify, constify, purify (function attributes) David Sterba
2019-10-02 12:20 ` Nikolay Borisov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69cb3c55-78ec-2060-c5a5-d238efef1206@suse.com \
--to=nborisov@suse.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox