From: Anand Jain <anand.jain@oracle.com>
To: David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 7/9] btrfs: remove extra sb::s_id from message in btrfs_validate_metadata_buffer
Date: Wed, 26 May 2021 20:54:22 +0800 [thread overview]
Message-ID: <6af7bb1e-6942-1f30-8e89-2221fb4b0cb0@oracle.com> (raw)
In-Reply-To: <9728b5a77818ff0c6ab80f2fa1de72c9f5c2ab32.1621961965.git.dsterba@suse.com>
On 26/05/2021 01:08, David Sterba wrote:
> The s_id is already printed by message helpers.
>
> Signed-off-by: David Sterba <dsterba@suse.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Thanks.
> ---
> fs/btrfs/disk-io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 8c3db9076988..6dc137684899 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -614,8 +614,8 @@ static int validate_extent_buffer(struct extent_buffer *eb)
>
> read_extent_buffer(eb, &val, 0, csum_size);
> btrfs_warn_rl(fs_info,
> - "%s checksum verify failed on %llu wanted " CSUM_FMT " found " CSUM_FMT " level %d",
> - fs_info->sb->s_id, eb->start,
> + "checksum verify failed on %llu wanted " CSUM_FMT " found " CSUM_FMT " level %d",
> + eb->start,
> CSUM_FMT_VALUE(csum_size, val),
> CSUM_FMT_VALUE(csum_size, result),
> btrfs_header_level(eb));
>
next prev parent reply other threads:[~2021-05-26 12:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 17:08 [PATCH 0/9] Misc fixups and cleanups David Sterba
2021-05-25 17:08 ` [PATCH 1/9] btrfs: sysfs: fix format string for some discard stats David Sterba
2021-05-25 23:47 ` Qu Wenruo
2021-05-26 6:01 ` Anand Jain
2021-05-25 17:08 ` [PATCH 2/9] btrfs: clear defrag status of a root if starting transaction fails David Sterba
2021-05-25 23:49 ` Qu Wenruo
2021-05-26 6:05 ` Anand Jain
2021-05-25 17:08 ` [PATCH 3/9] btrfs: clear log tree recovering status " David Sterba
2021-05-25 23:50 ` Qu Wenruo
2021-05-26 6:57 ` Anand Jain
2021-05-25 17:08 ` [PATCH 4/9] btrfs: scrub: factor out common scrub_stripe constraints David Sterba
2021-05-25 23:51 ` Qu Wenruo
2021-05-26 7:16 ` Anand Jain
2021-05-25 17:08 ` [PATCH 5/9] btrfs: document byte swap optimization of root_item::flags accessors David Sterba
2021-05-26 7:28 ` Anand Jain
2021-05-25 17:08 ` [PATCH 6/9] btrfs: reduce compressed_bio members' types David Sterba
2021-05-26 8:40 ` [PATCH] btrfs: optimize users of members of the struct compressed_bio Anand Jain
2021-05-26 16:34 ` David Sterba
2021-05-26 8:41 ` [PATCH 6/9] btrfs: reduce compressed_bio members' types Anand Jain
2021-05-25 17:08 ` [PATCH 7/9] btrfs: remove extra sb::s_id from message in btrfs_validate_metadata_buffer David Sterba
2021-05-25 23:59 ` Qu Wenruo
2021-05-26 12:54 ` Anand Jain [this message]
2021-05-25 17:08 ` [PATCH 8/9] btrfs: simplify eb checksum verification " David Sterba
2021-05-26 0:05 ` Qu Wenruo
2021-05-26 16:31 ` David Sterba
2021-05-26 16:58 ` David Sterba
2021-05-26 23:13 ` Qu Wenruo
2021-05-26 23:13 ` David Sterba
2021-05-25 17:08 ` [PATCH 9/9] btrfs: clean up header members offsets in write helpers David Sterba
2021-05-26 0:07 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6af7bb1e-6942-1f30-8e89-2221fb4b0cb0@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).