From: Lukas Middendorf <kernel@tuxforce.de>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-btrfs@vger.kernel.org, Antti Palosaari <crope@iki.fi>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org,
Lukas Middendorf <kernel@tuxforce.de>
Subject: Re: Is request_firmware() really safe to call in resume callback when /usr/lib/firmware is on btrfs?
Date: Thu, 1 Apr 2021 16:59:47 +0200 [thread overview]
Message-ID: <6b61e549-42b8-8e71-ff57-43b7c5b4291f@tuxforce.de> (raw)
In-Reply-To: <20200818143715.GF4332@42.do-not-panic.com>
Hello Luis,
On 18/08/2020 16:37, Luis Chamberlain wrote:
> On Tue, Aug 18, 2020 at 12:04:51AM +0200, Lukas Middendorf wrote:
>> On 17/08/2020 17:20, Luis Chamberlain wrote:
>>> This helps, thanks so much, now we'll have to write a reproducer, thanks
>>> for the report!!
>>
>> Will you do it yourself or do you expect me to do anything for this?
>
> I meant to imply that we'd do this, now that we understand the problem. Thanks
> for your report!
any news on this issue? Did you succeed with reproducing this at your end?
I retested this with 5.12-rc5 and everything still seems unchanged. I
still get freezes on resume under the same circumstances described
previously if /usr/lib/firmware is on btrfs. My patches to si2168.c were
not merged.
The documentation of request_firmware() seems unchanged and does not
reflect the fact that prerequisites exist for making it safe to call
during resume callbacks.
Lukas
next prev parent reply other threads:[~2021-04-01 18:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 18:51 Is request_firmware() really safe to call in resume callback when /usr/lib/firmware is on btrfs? Lukas Middendorf
2020-08-13 16:37 ` Luis Chamberlain
2020-08-13 21:53 ` Lukas Middendorf
2020-08-13 22:13 ` Luis Chamberlain
2020-08-14 11:38 ` Lukas Middendorf
2020-08-14 16:37 ` Luis Chamberlain
2020-08-14 21:59 ` Lukas Middendorf
2020-08-17 15:20 ` Luis Chamberlain
2020-08-17 22:04 ` Lukas Middendorf
2020-08-18 14:37 ` Luis Chamberlain
2021-04-01 14:59 ` Lukas Middendorf [this message]
2021-04-02 18:02 ` Luis Chamberlain
2021-04-02 22:19 ` Luis Chamberlain
2021-04-02 22:58 ` Luis Chamberlain
2021-04-03 10:24 ` Lukas Middendorf
2021-04-03 16:07 ` Lukas Middendorf
2021-04-03 20:25 ` Luis Chamberlain
2021-04-03 21:04 ` Luis Chamberlain
2021-04-05 9:52 ` Lukas Middendorf
2021-04-04 0:50 ` Lukas Middendorf
2021-04-08 18:02 ` Luis Chamberlain
2021-04-16 23:17 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b61e549-42b8-8e71-ff57-43b7c5b4291f@tuxforce.de \
--to=kernel@tuxforce.de \
--cc=crope@iki.fi \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).