From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v2 1/3] btrfs-progs: csum-change: add error handling for search old csums
Date: Fri, 21 Jun 2024 14:46:54 +0930 [thread overview]
Message-ID: <6bb6f483287cd3c15cabfabfbb81cc5c0392be32.1718946934.git.wqu@suse.com> (raw)
In-Reply-To: <cover.1718946934.git.wqu@suse.com>
Inside delete_old_data_csums(), after calling btrfs_search_slot() there
is no error handling at all.
Fix it by doing a proper error detection and abort the current transaction.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
tune/change-csum.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tune/change-csum.c b/tune/change-csum.c
index 0e7db20f5e6d..0f95cdb25533 100644
--- a/tune/change-csum.c
+++ b/tune/change-csum.c
@@ -395,6 +395,13 @@ static int delete_old_data_csums(struct btrfs_fs_info *fs_info)
int nr;
ret = btrfs_search_slot(trans, csum_root, &last_key, &path, -1, 1);
+ if (ret < 0) {
+ errno = -ret;
+ error("failed to search the last old csum item: %m");
+ btrfs_abort_transaction(trans, ret);
+ return ret;
+ }
+ assert(ret > 0);
nr = btrfs_header_nritems(path.nodes[0]);
/* No item left (empty csum tree), exit. */
--
2.45.2
next prev parent reply other threads:[~2024-06-21 5:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 5:16 [PATCH v2 0/3] btrfs-progs: btrfs-progs: csum-change enhancement Qu Wenruo
2024-06-21 5:16 ` Qu Wenruo [this message]
2024-06-21 5:16 ` [PATCH v2 2/3] btrfs-progs: csum-change: add leaf based threshold Qu Wenruo
2024-06-21 5:16 ` [PATCH v2 3/3] btrfs-progs: misc-tests: add a basic resume test using error injection Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bb6f483287cd3c15cabfabfbb81cc5c0392be32.1718946934.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox