Re: [PATCH] btrfs-progs: check: Sanitize the return value for qgroup error

David Sterba
2020-04-01T17:57:44Z

On Mon, Mar 30, 2020 at 03:01:59PM +0800, Qu Wenruo wrote:
> [BUG]
> btrfs check can return strange return value for shell:
> [Inferior 1 (process 48641) exited with code 0213]
> ^^^^
>
> [CAUSE]
> It's caused by the incorrect handling of qgroup error.
>
> qgroup_report_ret can be -117 (-EUCLEAN), using that value with exit()
> can cause overflow, causing return value not properly recognized.
>
> [FIX]
> Fix it by sanitize the return value to 0 or 1.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>

Added to devel, thanks.