From: Anand Jain <anand.jain@oracle.com>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: "dsterba@suse.cz" <dsterba@suse.cz>
Subject: Re: [RFC PATCH 0/2] Introduce blkdev_issue_flush_no_wait()
Date: Thu, 18 May 2017 17:27:06 +0800 [thread overview]
Message-ID: <6cc30419-c39c-de9f-0d0e-6c044ed75182@oracle.com> (raw)
In-Reply-To: <1494943642.2935.1.camel@sandisk.com>
On 05/16/2017 10:07 PM, Bart Van Assche wrote:
> On Tue, 2017-05-16 at 17:39 +0800, Anand Jain wrote:
>> BTRFS wanted a block device flush function which does not wait for
>> its completion, so that the flush for the next device can be called
>> in the same thread.
>>
>> Here is a RFC patch to provide the function
>> 'blkdev_issue_flush_no_wait()', which is based on the current device
>> flush function 'blkdev_issue_flush()', however it uses submit_bio()
>> instead of submit_bio_wait().
>>
>> This patch is for review comments, will send out a final patch based
>> on the comments received.
>
> Hello Anand,
>
> Since the block layer can reorder requests, I think using
> blkdev_issue_flush_no_wait() will only yield the intended result if
> the caller waits until the requests that have to be flushed have completed.
> Is that how you intend to use this function?
Yes. The patch 2/2 did that. Sorry for no explanation though.
Thanks, Anand
> Thanks,
>
> Bart.N�����r��y���b�X��ǧv�^�){.n�+����{�n�߲)���w*\x1fjg���\x1e�����ݢj/���z�ޖ��2�ޙ���&�)ߡ�a��\x7f��\x1e�G���h�\x0f�j:+v���w�٥
>
prev parent reply other threads:[~2017-05-18 9:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 9:39 [RFC PATCH 0/2] Introduce blkdev_issue_flush_no_wait() Anand Jain
2017-05-16 9:39 ` [PATCH 1/2] block: " Anand Jain
2017-05-16 11:56 ` Christoph Hellwig
2017-05-18 9:31 ` Anand Jain
2017-05-21 7:09 ` Christoph Hellwig
2017-05-24 8:42 ` Anand Jain
2017-05-16 9:39 ` [PATCH 2/2] btrfs: Use blkdev_issue_flush_no_wait() Anand Jain
2017-05-16 12:00 ` Christoph Hellwig
2017-05-16 14:07 ` [RFC PATCH 0/2] Introduce blkdev_issue_flush_no_wait() Bart Van Assche
2017-05-17 17:14 ` David Sterba
2017-05-18 9:31 ` Anand Jain
2017-05-18 9:27 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cc30419-c39c-de9f-0d0e-6c044ed75182@oracle.com \
--to=anand.jain@oracle.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=dsterba@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).