Re: [PATCH 0/4] btrfs-progs: check: add the ability to detect and report mixed inline and regular data extents

[Qu Wenruo <wqu@suse.com>]

On 2021/5/4 下午2:25, Qu Wenruo wrote:
> Btrfs check original mode can't detect mixed inline and regular data
> extents at all, while lowmem mode reports the problem as hole gap, not
> to the point.

Please discard the patchset.

We don't yet have an agreement on whether inline extent should be 
exclusive, and since kernel can handle it without any problem, it isn't 
something that urgent yet.

Furthermore the fix would be way more complex than I thought, as even on 
x86 we could reproduce such inline + regular extents, it's not that 
worthy yet.

Thanks,
Qu

> 
> This patchset will add the ability to detect such problem, with a test
> image dumped from subpage branch (with the inline extent disable patch
> reverted).
> 
> The patchset is here to detect such problem exposed during subpage
> development, while also acts as the final safenet to catch such mixed
> types bug.
> 
> Qu Wenruo (4):
>    btrfs-progs: check/original: add the "0x" prefix for hex error number
>    btrfs-progs: check/original: detect and report mixed inline and
>      regular data extents
>    btrfs-progs: check/lowmem: detect and report mixed inline and regular
>      extents properly
>    btrfs-progs: fsck-tests: add test image for mixed inline and regular
>      data extents
> 
>   check/main.c                                  |   7 +++-
>   check/mode-lowmem.c                           |  31 +++++++++++++++---
>   check/mode-original.h                         |   2 ++
>   .../047-mixed-extent-types/default.img.xz     | Bin 0 -> 2112 bytes
>   .../fsck-tests/047-mixed-extent-types/test.sh |  19 +++++++++++
>   5 files changed, 54 insertions(+), 5 deletions(-)
>   create mode 100644 tests/fsck-tests/047-mixed-extent-types/default.img.xz
>   create mode 100755 tests/fsck-tests/047-mixed-extent-types/test.sh
>