linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fb.com>
To: <fdmanana@gmail.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	<kernel-team@fb.com>
Subject: Re: [PATCH] Btrfs: handle pending renames with recycled inodes properly
Date: Wed, 24 Aug 2016 14:17:18 -0400	[thread overview]
Message-ID: <6e411424-555d-8052-7f49-08351a444c91@fb.com> (raw)
In-Reply-To: <CAL3q7H6pnkr+BDyAc4sMo7i15Lrmee+GUfc6cJnBFfpOFJVZiQ@mail.gmail.com>

On 08/24/2016 05:07 AM, Filipe Manana wrote:
> On Tue, Aug 23, 2016 at 6:22 PM, Josef Bacik <jbacik@fb.com> wrote:
>> Suppose you have the following tree in snap1 on a file system mounted with -o
>> inode_cache so that inode numbers are recycled
>>
>> └── [    258]  a
>>     └── [    257]  b
>>
>> and then you remove b, rename a to c, and then re-create b in c so you have the
>> following tree
>>
>> └── [    258]  c
>>     └── [    257]  b
>>
>> and then you try to do an incremental send you will hit
>>
>> ASSERT(pending_move == 0);
>
> Hi Josef,
>
> Would you care submitting a regression test for xfstests?
> The change looks good to me.
>

Yeah I sent one yesterday, btrfs/131.  Thanks,

Josef


      reply	other threads:[~2016-08-24 18:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23 17:22 [PATCH] Btrfs: handle pending renames with recycled inodes properly Josef Bacik
2016-08-24  9:07 ` Filipe Manana
2016-08-24 18:17   ` Josef Bacik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e411424-555d-8052-7f49-08351a444c91@fb.com \
    --to=jbacik@fb.com \
    --cc=fdmanana@gmail.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).