From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 272D7C43381 for ; Fri, 29 Mar 2019 09:40:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E44D920693 for ; Fri, 29 Mar 2019 09:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728415AbfC2Jkm (ORCPT ); Fri, 29 Mar 2019 05:40:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:44230 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726590AbfC2Jkm (ORCPT ); Fri, 29 Mar 2019 05:40:42 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 907A4AE99 for ; Fri, 29 Mar 2019 09:40:39 +0000 (UTC) Subject: Re: [PATCH 5/7] btrfs: check/lowmem: Check and repair free space cache inode mode To: Qu Wenruo , linux-btrfs@vger.kernel.org References: <20190325082253.19583-1-wqu@suse.com> <20190325082253.19583-6-wqu@suse.com> From: Nikolay Borisov Openpgp: preference=signencrypt Autocrypt: addr=nborisov@suse.com; prefer-encrypt=mutual; keydata= mQINBFiKBz4BEADNHZmqwhuN6EAzXj9SpPpH/nSSP8YgfwoOqwrP+JR4pIqRK0AWWeWCSwmZ T7g+RbfPFlmQp+EwFWOtABXlKC54zgSf+uulGwx5JAUFVUIRBmnHOYi/lUiE0yhpnb1KCA7f u/W+DkwGerXqhhe9TvQoGwgCKNfzFPZoM+gZrm+kWv03QLUCr210n4cwaCPJ0Nr9Z3c582xc bCUVbsjt7BN0CFa2BByulrx5xD9sDAYIqfLCcZetAqsTRGxM7LD0kh5WlKzOeAXj5r8DOrU2 GdZS33uKZI/kZJZVytSmZpswDsKhnGzRN1BANGP8sC+WD4eRXajOmNh2HL4P+meO1TlM3GLl EQd2shHFY0qjEo7wxKZI1RyZZ5AgJnSmehrPCyuIyVY210CbMaIKHUIsTqRgY5GaNME24w7h TyyVCy2qAM8fLJ4Vw5bycM/u5xfWm7gyTb9V1TkZ3o1MTrEsrcqFiRrBY94Rs0oQkZvunqia c+NprYSaOG1Cta14o94eMH271Kka/reEwSZkC7T+o9hZ4zi2CcLcY0DXj0qdId7vUKSJjEep c++s8ncFekh1MPhkOgNj8pk17OAESanmDwksmzh1j12lgA5lTFPrJeRNu6/isC2zyZhTwMWs k3LkcTa8ZXxh0RfWAqgx/ogKPk4ZxOXQEZetkEyTFghbRH2BIwARAQABtCNOaWtvbGF5IEJv cmlzb3YgPG5ib3Jpc292QHN1c2UuY29tPokCOAQTAQIAIgUCWIo48QIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQcb6CRuU/KFc0eg/9GLD3wTQz9iZHMFbjiqTCitD7B6dTLV1C ddZVlC8Hm/TophPts1bWZORAmYIihHHI1EIF19+bfIr46pvfTu0yFrJDLOADMDH+Ufzsfy2v HSqqWV/nOSWGXzh8bgg/ncLwrIdEwBQBN9SDS6aqsglagvwFD91UCg/TshLlRxD5BOnuzfzI Leyx2c6YmH7Oa1R4MX9Jo79SaKwdHt2yRN3SochVtxCyafDlZsE/efp21pMiaK1HoCOZTBp5 VzrIP85GATh18pN7YR9CuPxxN0V6IzT7IlhS4Jgj0NXh6vi1DlmKspr+FOevu4RVXqqcNTSS E2rycB2v6cttH21UUdu/0FtMBKh+rv8+yD49FxMYnTi1jwVzr208vDdRU2v7Ij/TxYt/v4O8 V+jNRKy5Fevca/1xroQBICXsNoFLr10X5IjmhAhqIH8Atpz/89ItS3+HWuE4BHB6RRLM0gy8 T7rN6ja+KegOGikp/VTwBlszhvfLhyoyjXI44Tf3oLSFM+8+qG3B7MNBHOt60CQlMkq0fGXd mm4xENl/SSeHsiomdveeq7cNGpHi6i6ntZK33XJLwvyf00PD7tip/GUj0Dic/ZUsoPSTF/mG EpuQiUZs8X2xjK/AS/l3wa4Kz2tlcOKSKpIpna7V1+CMNkNzaCOlbv7QwprAerKYywPCoOSC 7P25Ag0EWIoHPgEQAMiUqvRBZNvPvki34O/dcTodvLSyOmK/MMBDrzN8Cnk302XfnGlW/YAQ csMWISKKSpStc6tmD+2Y0z9WjyRqFr3EGfH1RXSv9Z1vmfPzU42jsdZn667UxrRcVQXUgoKg QYx055Q2FdUeaZSaivoIBD9WtJq/66UPXRRr4H/+Y5FaUZx+gWNGmBT6a0S/GQnHb9g3nonD jmDKGw+YO4P6aEMxyy3k9PstaoiyBXnzQASzdOi39BgWQuZfIQjN0aW+Dm8kOAfT5i/yk59h VV6v3NLHBjHVw9kHli3jwvsizIX9X2W8tb1SefaVxqvqO1132AO8V9CbE1DcVT8fzICvGi42 FoV/k0QOGwq+LmLf0t04Q0csEl+h69ZcqeBSQcIMm/Ir+NorfCr6HjrB6lW7giBkQl6hhomn l1mtDP6MTdbyYzEiBFcwQD4terc7S/8ELRRybWQHQp7sxQM/Lnuhs77MgY/e6c5AVWnMKd/z MKm4ru7A8+8gdHeydrRQSWDaVbfy3Hup0Ia76J9FaolnjB8YLUOJPdhI2vbvNCQ2ipxw3Y3c KhVIpGYqwdvFIiz0Fej7wnJICIrpJs/+XLQHyqcmERn3s/iWwBpeogrx2Lf8AGezqnv9woq7 OSoWlwXDJiUdaqPEB/HmGfqoRRN20jx+OOvuaBMPAPb+aKJyle8zABEBAAGJAh8EGAECAAkF AliKBz4CGwwACgkQcb6CRuU/KFdacg/+M3V3Ti9JYZEiIyVhqs+yHb6NMI1R0kkAmzsGQ1jU zSQUz9AVMR6T7v2fIETTT/f5Oout0+Hi9cY8uLpk8CWno9V9eR/B7Ifs2pAA8lh2nW43FFwp IDiSuDbH6oTLmiGCB206IvSuaQCp1fed8U6yuqGFcnf0ZpJm/sILG2ECdFK9RYnMIaeqlNQm iZicBY2lmlYFBEaMXHoy+K7nbOuizPWdUKoKHq+tmZ3iA+qL5s6Qlm4trH28/fPpFuOmgP8P K+7LpYLNSl1oQUr+WlqilPAuLcCo5Vdl7M7VFLMq4xxY/dY99aZx0ZJQYFx0w/6UkbDdFLzN upT7NIN68lZRucImffiWyN7CjH23X3Tni8bS9ubo7OON68NbPz1YIaYaHmnVQCjDyDXkQoKC R82Vf9mf5slj0Vlpf+/Wpsv/TH8X32ajva37oEQTkWNMsDxyw3aPSps6MaMafcN7k60y2Wk/ TCiLsRHFfMHFY6/lq/c0ZdOsGjgpIK0G0z6et9YU6MaPuKwNY4kBdjPNBwHreucrQVUdqRRm RcxmGC6ohvpqVGfhT48ZPZKZEWM+tZky0mO7bhZYxMXyVjBn4EoNTsXy1et9Y1dU3HVJ8fod 5UqrNrzIQFbdeM0/JqSLrtlTcXKJ7cYFa9ZM2AP7UIN9n1UWxq+OPY9YMOewVfYtL8M= Message-ID: <6e9857a2-163e-27f4-8128-7af73e5d18b1@suse.com> Date: Fri, 29 Mar 2019 11:40:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190325082253.19583-6-wqu@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 25.03.19 г. 10:22 ч., Qu Wenruo wrote: > Unlike inodes in fs roots, we don't really check the inode items in root > tree, in fact we just skip everything other than ROOT_ITEM and ROOT_REF. > > This makes invalid inode items sneak into root tree. > For example: > item 9 key (256 INODE_ITEM 0) itemoff 13702 itemsize 160 > generation 30 transid 30 size 65536 nbytes 1507328 > block group 0 mode 0 links 1 uid 0 gid 0 rdev 0 > ^ Should be 100600 > sequence 23 flags 0x1b(NODATASUM|NODATACOW|NOCOMPRESS|PREALLOC) > atime 0.0 (1970-01-01 08:00:00) > ctime 1553491158.189771625 (2019-03-25 13:19:18) > mtime 0.0 (1970-01-01 08:00:00) > otime 0.0 (1970-01-01 08:00:00) > > There is a report of such problem in the mail list. > > This patch will check and repair inode items of free space cache inodes in > lowmem mode. > > Since free space cache inodes doesn't have INODE_REF but still has 1 > link, we can't use check_inode_item() directly. > Instead we only check the inode mode, as that's the important part. > > The check and repair function: check_repair_free_space_inode() is also > exported for original mode. > > Signed-off-by: Qu Wenruo > --- > check/mode-common.h | 1 + > check/mode-lowmem.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ > check/mode-lowmem.h | 2 ++ > 3 files changed, 48 insertions(+) > > diff --git a/check/mode-common.h b/check/mode-common.h > index 8895747adf1d..855f83617854 100644 > --- a/check/mode-common.h > +++ b/check/mode-common.h > @@ -24,6 +24,7 @@ > #include > #include "ctree.h" > > +#define FREE_SPACE_CACHE_INODE_MODE (0100600) > /* > * Use for tree walk to walk through trees whose leaves/nodes can be shared > * between different trees. (Namely subvolume/fs trees) > diff --git a/check/mode-lowmem.c b/check/mode-lowmem.c > index f37c3b42e6b6..cdb9b66a63a3 100644 > --- a/check/mode-lowmem.c > +++ b/check/mode-lowmem.c > @@ -5091,6 +5091,40 @@ out: > return err; > } > > +/* > + * For free space inodes, we can't call check_inode_item() as free space > + * cache inode doesn't have INODE_REF. > + * We just check its inode mode. > + */ > +int check_repair_free_space_inode(struct btrfs_fs_info *fs_info, > + struct btrfs_path *path) > +{ > + struct btrfs_inode_item *iitem; > + struct btrfs_key key; > + u32 mode; > + int ret = 0; > + > + btrfs_item_key_to_cpu(path->nodes[0], &key, path->slots[0]); > + ASSERT(key.type == BTRFS_INODE_ITEM_KEY && is_fstree(key.objectid)); > + iitem = btrfs_item_ptr(path->nodes[0], path->slots[0], > + struct btrfs_inode_item); > + mode = btrfs_inode_mode(path->nodes[0], iitem); > + if (mode != FREE_SPACE_CACHE_INODE_MODE) { > + error( > + "free space cache inode %llu has invalid mode: has 0%o expect 0%o", > + key.objectid, mode, FREE_SPACE_CACHE_INODE_MODE); > + ret = -EUCLEAN; > + if (repair) { > + ret = repair_imode_lowmem(fs_info->tree_root, > + path); > + if (ret < 0) > + return ret; > + return ret; > + } > + } > + return ret; > +} You put this function in mode-lowmem, yet it's also used in the next patch to implement check/repair for original mode. Since you are oging to re-use function across the 2 modes it makes no sense to separate them in their names. Perhaps put them in mode-common.c > + > /* > * Check all fs/file tree in low_memory mode. > * > @@ -5130,6 +5164,17 @@ int check_fs_roots_lowmem(struct btrfs_fs_info *fs_info) > btrfs_item_key_to_cpu(node, &key, slot); > if (key.objectid > BTRFS_LAST_FREE_OBJECTID) > goto out; > + if (key.type == BTRFS_INODE_ITEM_KEY && > + is_fstree(key.objectid)) { > + ret = check_repair_free_space_inode(fs_info, &path); > + /* Check if we still have a valid path to continue */ > + if (ret < 0 && path.nodes[0]) { > + err |= ret; > + goto next; > + } > + if (ret < 0 && !path.nodes[0]) > + goto out; > + } > if (key.type == BTRFS_ROOT_ITEM_KEY && > fs_root_objectid(key.objectid)) { > if (key.objectid == BTRFS_TREE_RELOC_OBJECTID) { > diff --git a/check/mode-lowmem.h b/check/mode-lowmem.h > index e0ab30b770d5..d2983fd12eb4 100644 > --- a/check/mode-lowmem.h > +++ b/check/mode-lowmem.h > @@ -67,5 +67,7 @@ > > int check_fs_roots_lowmem(struct btrfs_fs_info *fs_info); > int check_chunks_and_extents_lowmem(struct btrfs_fs_info *fs_info); > +int check_repair_free_space_inode(struct btrfs_fs_info *fs_info, > + struct btrfs_path *path); > > #endif >