From: Anand Jain <anand.jain@oracle.com>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/5] btrfs: get device pointer from device_list_add()
Date: Wed, 10 Jan 2018 09:28:31 +0800 [thread overview]
Message-ID: <6ea75b55-88d1-c216-eae8-3319020910c1@oracle.com> (raw)
In-Reply-To: <20180109161338.mz7qtwfzbzv5jon6@destiny>
On 01/10/2018 12:13 AM, Josef Bacik wrote:
> On Tue, Jan 09, 2018 at 10:46:23PM +0800, Anand Jain wrote:
>> Instead of pointer to btrfs_fs_devices from device_list_add() its
>> better to get pointer to btrfs_device, then we have both, pointer
>> to btrfs_device and btrfs_fs_devices. This is needed in preparation
>> to add handling reappearing missing device feature.
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>
> Can we just change device_list_add to return struct btrfs_device * instead, and
> just do PTR_ERR() if there's a problem? Thanks,
That's much better. Will do.
Thanks, Anand
> Josef
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2018-01-10 1:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 14:46 [PATCH 0/5] device_list_add() peparation to add reappearing missing device Anand Jain
2018-01-09 14:46 ` [PATCH 1/5] btrfs: move pr_info into device_list_add Anand Jain
2018-01-09 16:12 ` Josef Bacik
2018-01-09 14:46 ` [PATCH 2/5] btrfs: set the total_devices in device_list_add() Anand Jain
2018-01-09 16:12 ` Josef Bacik
2018-01-09 14:46 ` [PATCH 3/5] btrfs: get device pointer from device_list_add() Anand Jain
2018-01-09 16:13 ` Josef Bacik
2018-01-10 1:28 ` Anand Jain [this message]
2018-01-09 14:46 ` [PATCH 4/5] btrfs: drop devid as device_list_add() arg Anand Jain
2018-01-09 16:14 ` Josef Bacik
2018-01-09 14:46 ` [PATCH 5/5] btrfs: move uuid_mutex closer to exclusivity Anand Jain
2018-01-09 16:15 ` Josef Bacik
2018-01-10 1:38 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ea75b55-88d1-c216-eae8-3319020910c1@oracle.com \
--to=anand.jain@oracle.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).