From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f53.google.com (mail-dl1-f53.google.com [74.125.82.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED2E02E6CA8 for ; Tue, 23 Dec 2025 05:35:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766468155; cv=none; b=kBksgChGn4n2w6aS518wVnnyF3JKNixi/cm2kld2OIMoqTUFsQzSF1q1YtrcSsr1qW4IobfzDXPRDD/gElLh1wBrFjFmDIQeFEwOfG6HFBBv1E2wo13QTUtCp//RuAJvVx5lBKdFn2Uf0ww6la4uKP8tuCH87StOvrmj0EJMzk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766468155; c=relaxed/simple; bh=g9Bt2s+UFC+DeXi/131tDLXltXct0EalOx5ApUtrNkg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q8EvXVQ/reXmZ7s0qaC+sTohXAUgJbSdlkwI+133PFPQ/JZmokP1I8lEvbyuqAiskMNB7yZAU7LxKjPqpJCPJ8fkly6B4N4QNXCnVRUWb1ctBU7ox7Tg0e7+i4uPnM/0HZubBq0xf5HajaUVxFnl7bFNHPkQE3FL9ezYc2PExvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LxX3T1Ps; arc=none smtp.client-ip=74.125.82.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LxX3T1Ps" Received: by mail-dl1-f53.google.com with SMTP id a92af1059eb24-11beb0a7bd6so7845103c88.1 for ; Mon, 22 Dec 2025 21:35:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766468152; x=1767072952; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1VDWjicrLkuqVcwGv9d1sh+ocm1fa0mGizT1YHR+Z6c=; b=LxX3T1PsbL7A9toWeCRP1ZiEISt/so3/Ge3jUHQW4vV4bDI+CFNh2mgvpyMRmaKHoT /MVJPZzIUDwB/OoYv1aOhJKvrOm2AivnEB8xW6vyl+8+1t7pR6MlWzwtRfU/GfflqC6K 3JQu8w0MC9/CxAeX4efBrU98BIUAeM6jx8wPEXyWQR3NDflVWRIrWEIxqQR4++JYkCHY bFEz1B+WB9h9jFH2Xqa8kzgS5ZTgD86P5uMkVxwxMjciEze4VsRaDj13pFlXKT13kVUf kH4LjKRVTROQaXbg91AnL4dtGRfgA1kC1ZeJH3Do0F3CuIrtVgeWGDs/NQy0SWkny28V x0fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766468152; x=1767072952; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1VDWjicrLkuqVcwGv9d1sh+ocm1fa0mGizT1YHR+Z6c=; b=aTSVTtxN+G0qw08w8kIrz9s68y/ZKwa1XXpt9ImUyaWL+ghLxf3X8QBK/w/r646hwe rRGiGaN8ocp07H/UwT0Or6o2S7rqxDxdusac4KKaPp8WqoQ3mOqcHrcarScqv62qDdql zTJjakufRISCgfLWlFArATlNjr0JOM/yYOHxxLvkNB+++e7MnrTT3U5rdniqKVSoHc+1 yX4/goGk/pxUTzdqEILTIeTpn58DJ48SnguyQ30+R+gilMzTWWXzWJbBY+a3KL0EXvJ1 OZxAZRPMLR/S1IcPHGI40oK9Q9O1n0ik2p6ubXuk4kRXfcRAStWm4QUR9YNl4TfkksKl 0DmA== X-Forwarded-Encrypted: i=1; AJvYcCXTWD+LfH/9FPsYxL8IvccMHCjgrx9vrWIp0VlveTcBcCJ3XPsTbNw4JUMptzg2rs0/WoCqqjzePOYIDw==@vger.kernel.org X-Gm-Message-State: AOJu0Yx3xqGPmgmDvHu7hol/9w8sG9IY68gNdPH0/xSNGWtRIDTAJiYW Lw1UrIxBvegE1ThVXmb4PyO0L1INdizB+ynCE9EdH81G5r8pC+BMTe/F X-Gm-Gg: AY/fxX6DLKt+j0ADzpMcqW9nCqmxaLquoOpVVntpTQp6vV6hJhS8+QssOQeVnkSqJ0j w/Wa9CLgkarzqnxVa/cYHvMI+8JrQeypsegXK0fz8wrNP3yLeRMnLMOeGPkZ/PK4jDbVYpPs6uM a10F4LZzecX4F/s55cxb/SLfxktqpvVRvQCFeCZjmf3A0nmCT6zXJA6deMV40S1KuNQvtGDRdEg SLEdiyHEuqV1sDyTvKMWKPlZ4TtLIJT1Abx9xFfH83tt1Dz1xdfxmJm9krxjmM92qL3pyccJyfq P7XPBXkfxMGGQuszJgAElEUCfzlLl94fVexrEcjelnWK0FSbi+jHQFDY4CwI72f5aYrf4YEG5ZZ RzgnkdPVV4+iX/U5IMzXzlQaMCGqyBPG3S2HFkuqti+Zdt/BmLwm/6Hw3pGIwRzBjAqdqDt/ezG mQnyjIfnw1zRXL/xlSoLav+qoz5cDzFDL07fDLW5JQLblYMgwKeCqzfWRnCQb2AE5R X-Google-Smtp-Source: AGHT+IFgD3SNwd/4TCZfokt7AW5oqjEJYNTcZgO21z1zxvgYYO/3rgL7QNl7uSOUpz7Nh4qCGFV22A== X-Received: by 2002:a05:7022:eacd:b0:11a:4ffb:984f with SMTP id a92af1059eb24-12171a85250mr15323051c88.11.1766468151780; Mon, 22 Dec 2025 21:35:51 -0800 (PST) Received: from ?IPV6:2600:8802:b00:9ce0:637f:5cdc:9df0:d9ab? ([2600:8802:b00:9ce0:637f:5cdc:9df0:d9ab]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121725548b5sm54725089c88.17.2025.12.22.21.35.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 21:35:51 -0800 (PST) Message-ID: <6f297260-3c99-4330-92ab-deeb1fc5d8f7@gmail.com> Date: Mon, 22 Dec 2025 21:35:50 -0800 Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/11] fs: delay the actual timestamp updates in inode_update_timestamps To: Christoph Hellwig , Christian Brauner Cc: Al Viro , David Sterba , Jan Kara , Mike Marshall , Martin Brandenburg , Carlos Maiolino , Stefan Roesch , Jeff Layton , linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev, io-uring@vger.kernel.org, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-mtd@lists.infradead.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org References: <20251223003756.409543-1-hch@lst.de> <20251223003756.409543-5-hch@lst.de> Content-Language: en-US From: Chaitanya Kulkarni In-Reply-To: <20251223003756.409543-5-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/22/25 16:37, Christoph Hellwig wrote: > Perform the actual updates of the inode timestamp at the very end of > inode_update_timestamps after finishing all checks. This prepares for > adding non-blocking timestamp updates where we might bail out instead of > performing this updates if the update would block. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Chaitanya Kulkarni -ck