Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>
Subject: [PATCH 04/12] btrfs: rename __compare_inode_defrag() and drop double underscores
Date: Tue, 27 Aug 2024 23:55:26 +0200	[thread overview]
Message-ID: <6f799faaf6cf515d0bd0c1825e15d3cdce201a4a.1724795624.git.dsterba@suse.com> (raw)
In-Reply-To: <cover.1724795623.git.dsterba@suse.com>

The function does not follow the pattern where the underscores would be
justified, so rename it.

Signed-off-by: David Sterba <dsterba@suse.com>
---
 fs/btrfs/defrag.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/btrfs/defrag.c b/fs/btrfs/defrag.c
index f6dbda37a361..e2949f630584 100644
--- a/fs/btrfs/defrag.c
+++ b/fs/btrfs/defrag.c
@@ -45,7 +45,7 @@ struct inode_defrag {
 	u32 extent_thresh;
 };
 
-static int __compare_inode_defrag(struct inode_defrag *defrag1,
+static int compare_inode_defrag(struct inode_defrag *defrag1,
 				  struct inode_defrag *defrag2)
 {
 	if (defrag1->root > defrag2->root)
@@ -83,7 +83,7 @@ static int __btrfs_add_inode_defrag(struct btrfs_inode *inode,
 		parent = *p;
 		entry = rb_entry(parent, struct inode_defrag, rb_node);
 
-		ret = __compare_inode_defrag(defrag, entry);
+		ret = compare_inode_defrag(defrag, entry);
 		if (ret < 0)
 			p = &parent->rb_left;
 		else if (ret > 0)
@@ -189,7 +189,7 @@ static struct inode_defrag *btrfs_pick_defrag_inode(
 		parent = p;
 		entry = rb_entry(parent, struct inode_defrag, rb_node);
 
-		ret = __compare_inode_defrag(&tmp, entry);
+		ret = compare_inode_defrag(&tmp, entry);
 		if (ret < 0)
 			p = parent->rb_left;
 		else if (ret > 0)
@@ -198,7 +198,7 @@ static struct inode_defrag *btrfs_pick_defrag_inode(
 			goto out;
 	}
 
-	if (parent && __compare_inode_defrag(&tmp, entry) > 0) {
+	if (parent && compare_inode_defrag(&tmp, entry) > 0) {
 		parent = rb_next(parent);
 		if (parent)
 			entry = rb_entry(parent, struct inode_defrag, rb_node);
-- 
2.45.0


  parent reply	other threads:[~2024-08-27 21:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-27 21:55 [PATCH 00/12] Renames and defrag cleanups David Sterba
2024-08-27 21:55 ` [PATCH 01/12] btrfs: rename btrfs_submit_bio() to btrfs_submit_bbio() David Sterba
2024-08-27 21:55 ` [PATCH 02/12] btrfs: rename __btrfs_submit_bio() and drop double underscores David Sterba
2024-08-27 21:55 ` [PATCH 03/12] btrfs: rename __extent_writepage() " David Sterba
2024-08-27 21:55 ` David Sterba [this message]
2024-08-27 21:55 ` [PATCH 05/12] btrfs: constify arguments of compare_inode_defrag() David Sterba
2024-08-27 21:55 ` [PATCH 06/12] btrfs: rename __need_auto_defrag() and drop double underscores David Sterba
2024-08-27 21:55 ` [PATCH 07/12] btrfs: rename __btrfs_add_inode_defrag() " David Sterba
2024-08-27 21:55 ` [PATCH 08/12] btrfs: rename __btrfs_run_defrag_inode() " David Sterba
2024-08-27 21:55 ` [PATCH 09/12] btrfs: clear defragmented inodes using postorder in btrfs_cleanup_defrag_inodes() David Sterba
2024-08-27 22:59   ` Qu Wenruo
2024-08-27 23:18     ` David Sterba
2024-08-27 23:48       ` Qu Wenruo
2024-08-28  0:11         ` David Sterba
2024-08-28  0:13           ` Qu Wenruo
2024-08-27 21:55 ` [PATCH 10/12] btrfs: return void from btrfs_add_inode_defrag() David Sterba
2024-08-27 21:55 ` [PATCH 11/12] btrfs: drop transaction parameter " David Sterba
2024-08-27 21:55 ` [PATCH 12/12] btrfs: always pass readahead state to defrag David Sterba
2024-08-27 23:02 ` [PATCH 00/12] Renames and defrag cleanups Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f799faaf6cf515d0bd0c1825e15d3cdce201a4a.1724795624.git.dsterba@suse.com \
    --to=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox