Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Mark Harmstone <maharmstone@meta.com>
To: Filipe Manana <fdmanana@kernel.org>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: add test for missing csums in log when doing async on subpage vol
Date: Tue, 8 Oct 2024 14:35:18 +0000	[thread overview]
Message-ID: <6f9235ff-004b-4754-80bc-757ec273a013@meta.com> (raw)
In-Reply-To: <CAL3q7H4izTkoF=RspYASMcn2wQK4cYpx8ecT84wSq2b+zsuNRQ@mail.gmail.com>

On 8/10/24 15:18, Filipe Manana wrote:
>>> There's also nothing in this test that is btrfs specific, it could be
>>> made a generic test instead.
>>
>> Yes there is, it's running btrfs check every time.
> 
> Right, but instead of calling it explicitly, it could pass
> "_check_scratch_fs" as an argument instead, and the test becomes
> generic:
> 
> _log_writes_fast_replay_check fua "$SCRATCH_DEV" "_check_scratch_fs"

Well, we could, but this is a test for a btrfs-specific race that 
existed between two known commits - this isn't a generic stress test. 
There's no reason to believe a) that other filesystems are vulnerable to 
this, or b) that their check programs would even pick it up.

Mark


  reply	other threads:[~2024-10-08 14:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-08 11:22 [PATCH] btrfs: add test for missing csums in log when doing async on subpage vol Mark Harmstone
2024-10-08 13:35 ` Filipe Manana
2024-10-08 14:06   ` Mark Harmstone
2024-10-08 14:18     ` Filipe Manana
2024-10-08 14:35       ` Mark Harmstone [this message]
2024-10-08 14:44         ` Filipe Manana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f9235ff-004b-4754-80bc-757ec273a013@meta.com \
    --to=maharmstone@meta.com \
    --cc=fdmanana@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox