Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Dhruva G <goledhruva@gmail.com>
To: Qu Wenruo <wqu@suse.com>,
	linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: btrfs: test if btrfs control file rejects unknown ioctls
Date: Mon, 12 Oct 2026 22:16:47 +0530	[thread overview]
Message-ID: <6fcc096d-c049-4a72-a33f-54aef6151a0e@gmail.com> (raw)
In-Reply-To: <20261011230716.16860-1-wqu@suse.com>

On 12-10-2026 04:37, Qu Wenruo wrote:
> This is a regression test for a recent bug fix, where unsupported ioctls
> are not properly rejected for btrfs control file (normally at
> "/dev/btrfs-control").
> 
> The test case itself is super simple, which doesn't even require test or
> scratch device, it just run the "btrfs_ioctl" program using
> "get_subvol_info" ioctl on "/dev/btrfs-control", which should fail as
> that ioctl only makes sense on a mounted btrfs, not the btrfs control
> file.
> 
> The error will be outputted to the golden output so that we can catch
> any unexpected success.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
>  tests/btrfs/359     | 26 ++++++++++++++++++++++++++

fails before the fix, passes after it on a local x86_64 Btrfs VM.

Tested-by: Dhruva Gole <goledhruva@gmail.com>
Reviewed-by: Dhruva Gole <goledhruva@gmail.com>

Regards,
Dhruva Gole

      parent reply	other threads:[~2026-10-12 16:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11 23:07 [PATCH] fstests: btrfs: test if btrfs control file rejects unknown ioctls Qu Wenruo
2026-10-12 11:27 ` Filipe Manana
2026-10-12 16:46 ` Dhruva G [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fcc096d-c049-4a72-a33f-54aef6151a0e@gmail.com \
    --to=goledhruva@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox