Re: [PATCH 0/5] Cleanups for later btrfs_alloc_chunk() rework

[Su Yue <suy.fnst@cn.fujitsu.com>]

On 01/03/2018 03:13 PM, Qu Wenruo wrote:
> Just small cleanups for incoming btrfs_alloc_chunk() rework, which is
> designed to allow btrfs_alloc_chunk() to be able to alloc meta chunk,
> even current meta chunks are already full.
> 
> The cleanups are quite small, most of them are just removing unnecessary
> parameters, and make some function static.
> 
> Qu Wenruo (5):
>    btrfs-progs: Use bool parameter to determine if we're allocating data
>      extent
>    btrfs-progs: volumes: Make find_free_dev_extent_start static
>    btrfs-progs: volumes: Remove unnecessary trans parameter
>    btrfs-progs: volumes: Remove unnecessary parameters when allocating
>      device extent
>    btrfs-progs: Remove unnecessary parameter for btrfs_add_block_group
> 

The series looks good to me.
Reviewed-by: Su Yue <suy.fnst@cn.fujitsu.com>

>   cmds-check.c   |  4 ++--
>   convert/main.c |  4 +---
>   ctree.h        |  7 +++----
>   extent-tree.c  | 31 ++++++++++++++++---------------
>   mkfs/main.c    | 14 ++++----------
>   volumes.c      | 35 ++++++++++++++---------------------
>   6 files changed, 40 insertions(+), 55 deletions(-)
>