From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 807933E9F8F for ; Mon, 2 Mar 2026 13:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772457856; cv=none; b=qIqbA64iq/JnRFvJsCoYIU5p7Zy/gEuzbMVxyKPP6r23f45mQG9Zr2T8Nc6CwJfcEU8xvxseYXCkV75ozQI42W2HW3HjMndfyEEGT7L5wxzsRobmPBu3brFVOZv1BEWKrTQOYW0IuZEmu7qtvJL1Kz5RyHxLm9ODjyoCdU6DAqU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772457856; c=relaxed/simple; bh=ltfsj99I78ai3Uw4cmgHT0d1UXB8XXPY1S98SmQRKs0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p9Oec/0sWX0Is/nLYYKVcsE9TnoC09IN+NP/HDTyr4x1vvw61bISgxo1J0vldtDsZEQlTgkn4HacmOjWFzYjis97zHNaSd29c4GCObmK7SqhyJcRWT4mWco+Jz/mVnhguWlhSQQ6JUXUwJRHW/eVdv4bpVcs4SNZsUdN2k8C0l4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LueOPztv; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LueOPztv" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8249fc726e9so2426659b3a.2 for ; Mon, 02 Mar 2026 05:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772457849; x=1773062649; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v9ZnDEvgwTfM42XxCeWf1ZWhMQzzUDLYvt9awp7GUwc=; b=LueOPztvjLS8TwLVZEA7S/Gqx4FUAvlFDty0m5Ywooe7fOv98qYJW5jZgNLf+dBVXL LDHJBQaDuMOVCpSXyW1+Ifxtrxx1k5aBtNnH2bops36EEp5mcPiOPW1dijZj1Czhbdp/ pZsaRzkSCMd1BdzxeRCthPqHRcn1DA6jZyy40+TlkrDM7menZPM6nH5P6RmWYEn14G4q mjcww6g4kmG1tdsC21C6nJlZYWHEXqKLEHd/cI70mBkKIt6yI8nFQYdhYyvAi4oj8qQH SKzV6RYep9VvN8RxJ5zmEyG44P3uYDiHRi8gHza32G3OS+HmEVQiquxEOGUwSF3IT4nI HL1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772457849; x=1773062649; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v9ZnDEvgwTfM42XxCeWf1ZWhMQzzUDLYvt9awp7GUwc=; b=r3RDuw3wWmwwZZ9FvfOnQfpnWbImL03060yhvXsg2FEIbsHzviV8qNoq1hm5T+X61z g0s2gUi0DJ/4ciAf27DvEBOgIstskJhpZhGPqeF7/N/Igb9gVntR1ehHOZ14qK5HlM1E bJVP8QvaK33MZz8dZIdnR6am0jC+nVUmT+6vZ28CnQ057ax6DnYRuHUa1TOtVqar4ui3 VDn0Ep3n5VRzvlMkONed+EUn7tkhGXEp1/ZKeS3RRlJjAawHZyTlkXrnai05Msi7UGgd kiu/f0nQL21jyJMPvUJhn+fvuUW3vKPqlvY1VLk/1C9c1UnS1fScsYSWnYop1AZyZrVb ns2w== X-Forwarded-Encrypted: i=1; AJvYcCW+J/ZQK+hgebzrzFuZr3EC6geaMz4ddhIAw/iqcxVA1HsIt1Ru37HNwFM0S+GWvU/ppm8nvkgkz5lRjA==@vger.kernel.org X-Gm-Message-State: AOJu0YzhmccuFmlwo4DuZMbiR5KIuwA9QPJGEr41Wu+dY+a9s2WcdIGe 2AewCIRH1RAcBUql6FWmKc9X+NK7DTon7hql7+BYxoGJcq1rEkVq/ReM5rz6wQ== X-Gm-Gg: ATEYQzx1K0CqgZxM6HssfZ+fOk3a173nHd4HquY7udo/60GO/usRFc1lVH+CEF3ITBl AA4FSrexCmHOZZYANg5/t1XQl8fWjJxmIqE1tfZtW6AkoiY91+ERxdSrsPmoi5N/Mb9+VKLUrbO Y8uAH8FiTvX9SCcOpQQk1IIybx6jlNQUbqxZjmsMMBOdak26lhYyeQlKuPAg2+qhN3zQgxjRH+U lFj4m2UGZcbxXnEHPG6ibCdSUtNAu9lBaAisKYYKQMCFsqkYuVnDbDWVsaLpOxtg2PijM5qwe6N F5L2idZu4+DiDr95u5DotoMM8A/NwfGemXqrwz3IK9Dz/P6SonG+4vlyewLrxyoHsNYOYJAY1pI jTP/yZ9RqKNcRH6H1pOURahG+cHxQwF/wVjULMb/JFxI3j4mNUWlP7k6TdsU2XPkecx5mv6L7V6 TUHkGcosUfYe99ezk0PIMSB4eGBq0= X-Received: by 2002:a05:6a00:3a25:b0:827:2891:c177 with SMTP id d2e1a72fcca58-8274da2fee7mr8658465b3a.64.1772457848572; Mon, 02 Mar 2026 05:24:08 -0800 (PST) Received: from [192.168.50.90] ([116.87.14.48]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8273a05e831sm13446967b3a.58.2026.03.02.05.24.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 05:24:08 -0800 (PST) Message-ID: <73e51635-e461-4292-a858-f73ea4d23545@gmail.com> Date: Mon, 2 Mar 2026 21:24:05 +0800 Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/9] fstests: add test for inotify isolation on cloned devices To: Amir Goldstein , Anand Jain Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, Jan Kara References: <78014ba3d564004081dca3c1d7e69cec8943f629.1772095513.git.asj@kernel.org> Content-Language: en-US From: Anand Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit >> +_cleanup() >> +{ >> + cd / >> + rm -r -f $tmp.* >> + umount $mnt1 $mnt2 2>/dev/null >> + _scratch_dev_pool_put >> +} >> + >> +_scratch_dev_pool_get 2 >> +_scratch_mkfs_sized_clone >$seqres.full 2>&1 >> +devs=($SCRATCH_DEV_POOL) >> +mnt2=$TEST_DIR/mnt2 >> +mkdir -p $mnt2 >> + >> +_scratch_mount $(_clone_mount_option) >> +_mount $(_common_dev_mount_options) $(_clone_mount_option) ${devs[1]} $mnt2 || \ >> + _fail "Failed to mount dev2" >> + >> +log1=$tmp.inotify1 >> +log2=$tmp.inotify2 >> + >> +echo "Setup inotify watchers on both SCRATCH_MNT and mnt2" >> +$INOTIFYWAIT_PROG -m -e create --format '%f' $SCRATCH_MNT > $log1 2>&1 & >> +pid1=$! >> +$INOTIFYWAIT_PROG -m -e create --format '%f' $mnt2 > $log2 2>&1 & >> +pid2=$! >> +sleep 2 >> + >> +echo "Trigger file creation on SCRATCH_MNT" >> +touch $SCRATCH_MNT/file_on_scratch_mnt >> +sync >> +sleep 1 >> + >> +echo "Trigger file creation on mnt2" >> +touch $mnt2/file_on_mnt2 >> +sync >> +sleep 1 >> + >> +echo "Verify inotify isolation" >> +kill $pid1 $pid2 >> +wait $pid1 $pid2 2>/dev/null > > I think you also need to take care of killing the bg process > in _cleanup() so that the test could be cleanly aborted. You are right, SIGINT can terminate the testcase at any point, we need kill(1) in _cleanup(). I'll fix this in v2. Thanks, Anand