public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcos Paulo de Souza <mpdesouza@suse.de>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Cc: Tyler Richmond <t.d.richmond@gmail.com>
Subject: Re: [PATCH] btrfs: tree-checker: fix the error message for transid error
Date: Tue, 25 Aug 2020 10:55:24 -0300	[thread overview]
Message-ID: <7482b8795905e02acf018580dfd88f59ca3dd1b3.camel@suse.de> (raw)
In-Reply-To: <20200825134251.31609-1-wqu@suse.com>

On Tue, 2020-08-25 at 21:42 +0800, Qu Wenruo wrote:
> The error message for inode transid is the same for inode generation,
> which makes us unable to detect the real problem.

LGTM,

Reviewed-by: Marcos Paulo de Souza <mpdesouza@suse.com>

> 
> Reported-by: Tyler Richmond <t.d.richmond@gmail.com>
> Fixes: 496245cac57e ("btrfs: tree-checker: Verify inode item")
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
>  fs/btrfs/tree-checker.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
> index 517b44300a05..7b1fee630f97 100644
> --- a/fs/btrfs/tree-checker.c
> +++ b/fs/btrfs/tree-checker.c
> @@ -984,7 +984,7 @@ static int check_inode_item(struct extent_buffer
> *leaf,
>  	/* Note for ROOT_TREE_DIR_ITEM, mkfs could set its transid 0 */
>  	if (btrfs_inode_transid(leaf, iitem) > super_gen + 1) {
>  		inode_item_err(leaf, slot,
> -			"invalid inode generation: has %llu expect [0,
> %llu]",
> +			"invalid inode transid: has %llu expect [0,
> %llu]",
>  			       btrfs_inode_transid(leaf, iitem),
> super_gen + 1);
>  		return -EUCLEAN;
>  	}


  reply	other threads:[~2020-08-25 13:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 13:42 [PATCH] btrfs: tree-checker: fix the error message for transid error Qu Wenruo
2020-08-25 13:55 ` Marcos Paulo de Souza [this message]
2020-08-26 11:17 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7482b8795905e02acf018580dfd88f59ca3dd1b3.camel@suse.de \
    --to=mpdesouza@suse.de \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=t.d.richmond@gmail.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox