Re: [PATCH v3 0/4] kstrtox: introduce memparse_safe()

Andy Shevchenko
2024-01-14T13:42:45Z

On Sun, Jan 07, 2024 at 07:28:27AM +1030, Qu Wenruo wrote:
> On 2024/1/7 01:04, Andy Shevchenko wrote:
> > On Thu, Jan 04, 2024 at 09:57:47AM +1030, Qu Wenruo wrote:

...

> > Having test cases is quite good, thanks!
> > But as I understood what Alexey wanted, is not using the kstrtox files for this.
> > You can introduce it in the cmdline.c, correct? Just include local "kstrtox.h".
>
> Not really possible, all the needed parsing helpers are internal inside
> kstrtox.c.

I'm not sure I follow. The functions are available to other library (built-in)
modules.

> Furthermore, this also means memparse() can not be enhanced due to:
>
> - Lack of ways to return errors

What does this mean?

> - Unable to call the parsing helpers inside cmdline.c

??? (see above)

--
With Best Regards,
Andy Shevchenko