From: Anand Jain <anand.jain@oracle.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 3/9] geneirc/077 fix min size for btrfs
Date: Thu, 11 Oct 2018 11:14:36 +0800 [thread overview]
Message-ID: <7874ee99-960a-e6c4-b710-d7a24bd9d64c@oracle.com> (raw)
In-Reply-To: <20181006112507.GL17817@desktop>
On 10/06/2018 07:25 PM, Eryu Guan wrote:
> On Tue, Sep 25, 2018 at 12:24:16PM +0800, Anand Jain wrote:
>> If btrfs need to be tested at its default blockgroup which is non-mixed,
>> then it needs at least 256mb.
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>
> (Sorry for the late review..)
Its fine. Sorry for the delay at my end too.
>> ---
>> tests/generic/077 | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/tests/generic/077 b/tests/generic/077
>> index ef6af18c83e3..ec236992513f 100755
>> --- a/tests/generic/077
>> +++ b/tests/generic/077
>> @@ -49,8 +49,7 @@ rm -f $seqres.full
>> _scratch_unmount >/dev/null 2>&1
>> echo "*** MKFS ***" >>$seqres.full
>> echo "" >>$seqres.full
>> -SIZE=`expr 50 \* 1024 \* 1024`
>> -_scratch_mkfs_sized $SIZE >>$seqres.full 2>&1 \
>> +_scratch_mkfs_sized $((256 * 1024 *1024)) >>$seqres.full 2>&1 \
>> || _fail "mkfs failed"
>
> Hmm, this test copies "/lib/modules/" to fill the original 50M
> filesystem (which seems a bad way to me)
Yep. I didn't like either. I started using the _populate_fs() but then
was doubtful if it still meets the objective of this test case as it
used the dd instead of cp. Moreover it kind of getting diverged from
what's the object of this patch. If needed we could fix the cp approach
in a separate patch so that we shall have better tracking.
> "
> # Something w/ enough data to fill 50M of fs...
> filler=/lib/modules/
> ...
> echo "*** populate filesystem, pass #1" | tee -a $seqres.full
> cp -rf $filler $SCRATCH_MNT/subdir >$seqres.full 2>&1
> ...
> "
>
> It works most of the time as "/lib/modules" is usually larger than 50M,
> but it may not fullfil the fs with 256M size.
>
> I think we should fix the way to fill the fs too.
Right. There are two iterations of cp. So a check if the assigned
filler is big enough to fill the 256M will suffice, as we already
_notrun the test if empty filler.
Pls find v2 for review.
Thanks, Anand
> Thanks,
> Eryu
>
>> _scratch_mount
>> mkdir $SCRATCH_MNT/subdir
>> --
>> 1.8.3.1
>>
next prev parent reply other threads:[~2018-10-11 3:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 4:24 [PATCH v2 0/9] Fix _scratch_mkfs_sized() for btrfs Anand Jain
2018-09-25 4:24 ` [PATCH v2 1/9] fstests: btrfs: _scratch_mkfs_sized fix min size without mixed option Anand Jain
2018-09-25 10:51 ` Nikolay Borisov
2018-09-26 4:07 ` Anand Jain
2018-09-26 6:34 ` Nikolay Borisov
2018-09-26 6:37 ` Anand Jain
2018-09-27 20:07 ` Omar Sandoval
2018-09-28 13:23 ` Anand Jain
2018-09-25 4:24 ` [PATCH v2 2/9] generic/015 fix to test the default non-mixed mode Anand Jain
2018-09-25 10:55 ` Nikolay Borisov
2018-09-25 4:24 ` [PATCH v2 3/9] geneirc/077 fix min size for btrfs Anand Jain
2018-10-06 11:25 ` Eryu Guan
2018-10-11 3:14 ` Anand Jain [this message]
2018-10-11 3:27 ` Anand Jain
2018-09-25 4:24 ` [PATCH v2 4/9] generic/083 fix btrfs fs size for default mode Anand Jain
2018-09-25 4:24 ` [PATCH v2 5/9] generic/102 open code dev_size _scratch_mkfs_sized() Anand Jain
2018-09-25 10:54 ` Nikolay Borisov
2018-09-26 4:08 ` Anand Jain
2018-10-07 15:18 ` Eryu Guan
2018-09-25 4:24 ` [PATCH v2 6/9] generic/204 open code SIZE for _scratch_mkfs_sized() Anand Jain
2018-09-25 4:24 ` [PATCH v2 7/9] generic/312 open code fs_size _scratch_mkfs_sized() Anand Jain
2018-09-25 4:24 ` [PATCH v2 8/9] generic/449 fix fs size for _scratch_mkfs_sized for btrfs Anand Jain
2018-09-25 4:24 ` [PATCH v2 9/9] generic/387 fix _scratch_mkfs_sized option " Anand Jain
2018-09-25 6:42 ` [PATCH v2 0/9] Fix _scratch_mkfs_sized() " Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7874ee99-960a-e6c4-b710-d7a24bd9d64c@oracle.com \
--to=anand.jain@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).