Re: [PATCH] generic/442: fix failure due to missing test number argument for fsync-err

Qu Wenruo
2024-12-17T07:58:06Z

在 2024/12/11 04:08, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
>
> After commit 88c0291d297c ("fstests: per-test dmerror instances") the
> script src/dmerror now has an extra argument, corresponding to a test's
> sequence number, but generic/442 isn't passing that argument so the test
> fails like this:
>
> $ ./check generic/442
> FSTYP -- btrfs
> PLATFORM -- Linux/x86_64 debian0 6.13.0-rc1-btrfs-next-181+ #1 SMP PREEMPT_DYNAMIC Tue Dec 3 13:03:23 WET 2024
> MKFS_OPTIONS -- /dev/sdc
> MOUNT_OPTIONS -- /dev/sdc /home/fdmanana/btrfs-tests/scratch_1
>
> generic/442 4s ... - output mismatch (see /home/fdmanana/git/hub/xfstests/results//generic/442.out.bad)
> --- tests/generic/442.out 2020-06-10 19:29:03.850519863 +0100
> +++ /home/fdmanana/git/hub/xfstests/results//generic/442.out.bad 2024-12-10 17:35:59.746597468 +0000
> @@ -1,2 +1,3 @@
> QA output created by 442
> -Test passed!
> +Usage: /home/fdmanana/git/hub/xfstests/src/dmerror {load_error_table|load_working_table}
> +system: program exited: 1
> ...
> (Run 'diff -u /home/fdmanana/git/hub/xfstests/tests/generic/442.out /home/fdmanana/git/hub/xfstests/results//generic/442.out.bad' to see the entire diff)
> Ran: generic/442
> Failures: generic/442
> Failed 1 of 1 tests
>
> Fix this by passing the test's sequence number as an argument.
>
> Fixes: 88c0291d297c ("fstests: per-test dmerror instances")
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

BTW, generic/441 has one debug seqres.full output containing the old
command, which is desynced from the real command.

Thanks,
Qu

> ---
> tests/generic/442 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/442 b/tests/generic/442
> index c1182b5a..ac1b094a 100755
> --- a/tests/generic/442
> +++ b/tests/generic/442
> @@ -29,7 +29,7 @@ _require_test_program dmerror
>
> _dmerror_init
>
> -$here/src/fsync-err -d $here/src/dmerror $DMERROR_DEV
> +$here/src/fsync-err -d "$here/src/dmerror $seq" $DMERROR_DEV
>
> # success, all done
> _dmerror_load_working_table