From: Josef Bacik <josef@toxicpanda.com>
To: Anand Jain <anand.jain@oracle.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/1] btrfs: cleanup btrfs_free_extra_devids() drop arg step
Date: Fri, 6 Nov 2020 11:51:59 -0500 [thread overview]
Message-ID: <78d7fc4c-228c-378f-1a23-bf3e37cdb165@toxicpanda.com> (raw)
In-Reply-To: <a20a37162b49e5b1de7a5ec70607102b61ac94eb.1604649817.git.anand.jain@oracle.com>
On 11/6/20 3:06 AM, Anand Jain wrote:
> Following patch
> btrfs: dev-replace: fail mount if we don't have replace item with target device
> dropped the multi ops of the function btrfs_free_extra_devids(), where now
This is jumbled together so I was confused, write it like
The following patch
btrfs: dev-replace: fail mount if we don't have replace item with target device
dropped the usage of the step argument in btrfs_free_extra_devids()
Other than that the code is fine, you can fix that up and add
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
next prev parent reply other threads:[~2020-11-06 16:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 8:06 [PATCH 0/1] cleanup btrfs_free_extra_devids() drop arg step Anand Jain
2020-11-06 8:06 ` [PATCH 1/1] btrfs: " Anand Jain
2020-11-06 16:51 ` Josef Bacik [this message]
2020-11-06 17:02 ` Josef Bacik
2020-11-06 23:41 ` Anand Jain
2020-11-11 14:57 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78d7fc4c-228c-378f-1a23-bf3e37cdb165@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).