From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49957C2D0A3 for ; Fri, 6 Nov 2020 16:52:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D356520720 for ; Fri, 6 Nov 2020 16:52:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="JU6qyMJ6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726074AbgKFQwD (ORCPT ); Fri, 6 Nov 2020 11:52:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbgKFQwD (ORCPT ); Fri, 6 Nov 2020 11:52:03 -0500 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD47CC0613CF for ; Fri, 6 Nov 2020 08:52:01 -0800 (PST) Received: by mail-qk1-x744.google.com with SMTP id c27so1633340qko.10 for ; Fri, 06 Nov 2020 08:52:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=jfpPPtgirsmC1cpI2lD2w0HZR5dgOEys4zOQywxpDgU=; b=JU6qyMJ6uQNLW+jzK3U8GibI6JIr+m2gyjTXw73A+ywXvsD8SIFXgnizp4xYtmZ7ya GVzw7u11OEaV3PelrQ+hRo/h+WwqYyhUfoV6wJWV3lNMIBGjqktsaUn2IDk0LX8zU7Zd RrWcqv3QubLmF/1MbOrnwHtS9Z0LtpkkVfL3zefmbyTaehHIJS39OGog6sUvCGkWrRQg QQ6468JK12Qa616HMvRQj2OAcA7y0uYEFfWwrkLUVeUx647TEuMwH1TqAArcxh/4VlfI A6vQYBbZSABVvh4OYiw3VtXFP3YTxaHzdiQwY/7dw33jq7MGW6iw+8d3lzlq4+M0SNa2 a4XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jfpPPtgirsmC1cpI2lD2w0HZR5dgOEys4zOQywxpDgU=; b=UtM0U5kJowidDjjKFO5Yg2GPIS4hbUuNF2E88fcTvNNnsr2D/aJb4yXa0EvmMUhhd7 CEMPTCl9pvcC5yUdKIwurJZR+X62Xhb24ZmDm/I1gna+xBLHmhv2nIDyTSEj4Y7nHjGw 37XYnoFKHWYe0xjAHV260Ae7q4P20/ISAaKhQ252eZi8LXZCXxKOMBRdIDjNhPivEr1x gedIkfxZVaFOIk+ot70xTnWb3siL/7PDl/oPF6nYFIXYkVevf38YFxRgssujk6fjLMbG VbrNJhbuvMinywN/Ifo/9w49i83Gjrjf6ETMpT0aEav6DzfhJJNWE6DEG4Rk9gdgQ6aJ A2CA== X-Gm-Message-State: AOAM5324qQ3wS118GUEXuaqazdMTXpoPIbhjMKCeBVsxe/NS5tsYMKO2 1NVsd/mOiet7ENvGvd3Vqr/dBM1Iu4uL2NjJ X-Google-Smtp-Source: ABdhPJwjdUmI7lt0Fo8GhLht2MaIuU55BYH0rZC1cYtf+/v7BZIWm9ATGhVHJjMidaLKSz3ggUTG8w== X-Received: by 2002:a37:6697:: with SMTP id a145mr2523844qkc.296.1604681520858; Fri, 06 Nov 2020 08:52:00 -0800 (PST) Received: from [192.168.1.45] (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id x72sm252823qkb.90.2020.11.06.08.51.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Nov 2020 08:52:00 -0800 (PST) Subject: Re: [PATCH 1/1] btrfs: cleanup btrfs_free_extra_devids() drop arg step To: Anand Jain , linux-btrfs@vger.kernel.org References: From: Josef Bacik Message-ID: <78d7fc4c-228c-378f-1a23-bf3e37cdb165@toxicpanda.com> Date: Fri, 6 Nov 2020 11:51:59 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 11/6/20 3:06 AM, Anand Jain wrote: > Following patch > btrfs: dev-replace: fail mount if we don't have replace item with target device > dropped the multi ops of the function btrfs_free_extra_devids(), where now This is jumbled together so I was confused, write it like The following patch btrfs: dev-replace: fail mount if we don't have replace item with target device dropped the usage of the step argument in btrfs_free_extra_devids() Other than that the code is fine, you can fix that up and add Reviewed-by: Josef Bacik Thanks, Josef