From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60105C38BF9 for ; Mon, 24 Feb 2020 21:27:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F58A218AC for ; Mon, 24 Feb 2020 21:27:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727421AbgBXV1h (ORCPT ); Mon, 24 Feb 2020 16:27:37 -0500 Received: from mx2.suse.de ([195.135.220.15]:42268 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726722AbgBXV1h (ORCPT ); Mon, 24 Feb 2020 16:27:37 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1B7FBAEA7; Mon, 24 Feb 2020 21:27:36 +0000 (UTC) Message-ID: <795cb7cc9d36eb84c1ed03efdbb8702ef9282774.camel@suse.de> Subject: Re: [PATCH misc-next] btrfs: fix compilation error in btree_write_cache_pages() From: Marcos Paulo de Souza To: Johannes Thumshirn , David Sterba Cc: Qu Wenruo , "linux-btrfs @ vger . kernel . org" Date: Mon, 24 Feb 2020 18:30:38 -0300 In-Reply-To: <20200224202251.37787-1-johannes.thumshirn@wdc.com> References: <20200224202251.37787-1-johannes.thumshirn@wdc.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, 2020-02-25 at 05:22 +0900, Johannes Thumshirn wrote: > CC [M] fs/btrfs/extent_io.o > fs/btrfs/extent_io.c: In function ‘btree_write_cache_pages’: > fs/btrfs/extent_io.c:3959:34: error: ‘tree’ undeclared (first use in > this function); did you mean ‘true’? > 3959 | struct btrfs_fs_info *fs_info = tree->fs_info; > | ^~~~ > | true > fs/btrfs/extent_io.c:3959:34: note: each undeclared identifier is > reported only once for each function it appears in > make[2]: *** [scripts/Makefile.build:268: fs/btrfs/extent_io.o] Error > 1 > make[1]: *** [scripts/Makefile.build:505: fs/btrfs] Error 2 > make: *** [Makefile:1681: fs] Error 2 > > Fixes: 75c39607eb0a ("btrfs: Don't submit any btree write bio if the > fs has errors") > Signed-off-by: Johannes Thumshirn Indeed, it fixes the build of misc-next. Reviewed-by: Marcos Paulo de Souza > --- > fs/btrfs/extent_io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c > index 903a85d8fbe3..837262d54e28 100644 > --- a/fs/btrfs/extent_io.c > +++ b/fs/btrfs/extent_io.c > @@ -3956,7 +3956,7 @@ int btree_write_cache_pages(struct > address_space *mapping, > .extent_locked = 0, > .sync_io = wbc->sync_mode == WB_SYNC_ALL, > }; > - struct btrfs_fs_info *fs_info = tree->fs_info; > + struct btrfs_fs_info *fs_info = BTRFS_I(mapping->host)->root- > >fs_info; > int ret = 0; > int done = 0; > int nr_to_write_done = 0;