From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A0DDC433E0 for ; Tue, 9 Feb 2021 09:56:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B48D64E92 for ; Tue, 9 Feb 2021 09:56:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230263AbhBIJz6 (ORCPT ); Tue, 9 Feb 2021 04:55:58 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:8552 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229963AbhBIJxt (ORCPT ); Tue, 9 Feb 2021 04:53:49 -0500 X-IronPort-AV: E=Sophos;i="5.81,164,1610380800"; d="scan'208";a="104368304" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 09 Feb 2021 17:46:18 +0800 Received: from G08CNEXMBPEKD05.g08.fujitsu.local (unknown [10.167.33.204]) by cn.fujitsu.com (Postfix) with ESMTP id 7E31B4CE6F81; Tue, 9 Feb 2021 17:46:13 +0800 (CST) Received: from irides.mr (10.167.225.141) by G08CNEXMBPEKD05.g08.fujitsu.local (10.167.33.204) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 9 Feb 2021 17:46:12 +0800 Subject: Re: [PATCH 5/7] fsdax: Dedup file range to use a compare function To: Christoph Hellwig CC: , , , , , , , , , , , , , Goldwyn Rodrigues References: <20210207170924.2933035-1-ruansy.fnst@cn.fujitsu.com> <20210207170924.2933035-6-ruansy.fnst@cn.fujitsu.com> <20210208151920.GE12872@lst.de> <9193e305-22a1-3928-0675-af1cecd28942@cn.fujitsu.com> <20210209093438.GA630@lst.de> From: Ruan Shiyang Message-ID: <79b0d65c-95dd-4821-e412-ab27c8cb6942@cn.fujitsu.com> Date: Tue, 9 Feb 2021 17:46:13 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210209093438.GA630@lst.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.167.225.141] X-ClientProxiedBy: G08CNEXCHPEKD04.g08.fujitsu.local (10.167.33.200) To G08CNEXMBPEKD05.g08.fujitsu.local (10.167.33.204) X-yoursite-MailScanner-ID: 7E31B4CE6F81.AEF5B X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: ruansy.fnst@cn.fujitsu.com Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 2021/2/9 下午5:34, Christoph Hellwig wrote: > On Tue, Feb 09, 2021 at 05:15:13PM +0800, Ruan Shiyang wrote: >> The dax dedupe comparison need the iomap_ops pointer as argument, so my >> understanding is that we don't modify the argument list of >> generic_remap_file_range_prep(), but move its code into >> __generic_remap_file_range_prep() whose argument list can be modified to >> accepts the iomap_ops pointer. Then it looks like this: > > I'd say just add the iomap_ops pointer to > generic_remap_file_range_prep and do away with the extra wrappers. We > only have three callers anyway. OK. -- Thanks, Ruan Shiyang. > >