Re: [PATCH] btrfs: Add more details while checking tree block

[Nikolay Borisov <nborisov@suse.com>]

On 22.06.2018 04:52, Su Yue wrote:
> For easier debug, print eb->start if level is invalid.
> Also make print clear if bytenr found is not expected.
> 
> Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
> ---
>  fs/btrfs/disk-io.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index c3504b4d281b..a90dab84f41b 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -615,8 +615,8 @@ static int btree_readpage_end_io_hook(struct btrfs_io_bio *io_bio,
>  
>  	found_start = btrfs_header_bytenr(eb);
>  	if (found_start != eb->start) {
> -		btrfs_err_rl(fs_info, "bad tree block start %llu %llu",
> -			     found_start, eb->start);
> +		btrfs_err_rl(fs_info, "bad tree block start want %llu have %llu",

nit: I'd rather have the want/have in brackets (want %llu have% llu)

> +			     eb->start, found_start);
>  		ret = -EIO;
>  		goto err;
>  	}
> @@ -628,8 +628,8 @@ static int btree_readpage_end_io_hook(struct btrfs_io_bio *io_bio,
>  	}
>  	found_level = btrfs_header_level(eb);
>  	if (found_level >= BTRFS_MAX_LEVEL) {
> -		btrfs_err(fs_info, "bad tree block level %d",
> -			  (int)btrfs_header_level(eb));
> +		btrfs_err(fs_info, "bad tree block level %d on %llu",
> +			  (int)btrfs_header_level(eb), eb->start);
>  		ret = -EIO;
>  		goto err;
>  	}
>