From: Marcos Paulo de Souza <mpdesouza@suse.de>
To: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/3] btrfs: use ioctl args support mask for subvolume create/delete
Date: Fri, 21 Feb 2020 10:21:08 -0300 [thread overview]
Message-ID: <7b553cc689aab3349caf2f0ba69a393127b37046.camel@suse.de> (raw)
In-Reply-To: <4b8a60420b7da2f62f04969541b3405fc14914e6.1582289899.git.dsterba@suse.com>
On Fri, 2020-02-21 at 14:02 +0100, David Sterba wrote:
> Using the defined mask instead of flag enumeration in the ioctl
> handler
> is preferred. No functional changes.
>
> Signed-off-by: David Sterba <dsterba@suse.com>
> ---
> fs/btrfs/ioctl.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 7305e6770157..a7872cacd0aa 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -1838,9 +1838,7 @@ static noinline int
> btrfs_ioctl_snap_create_v2(struct file *file,
> return PTR_ERR(vol_args);
> vol_args->name[BTRFS_SUBVOL_NAME_MAX] = '\0';
>
> - if (vol_args->flags &
> - ~(BTRFS_SUBVOL_CREATE_ASYNC | BTRFS_SUBVOL_RDONLY |
> - BTRFS_SUBVOL_QGROUP_INHERIT)) {
> + if (vol_args->flags & ~BTRFS_SUBVOL_CREATE_ARGS_MASK) {
> ret = -EOPNOTSUPP;
> goto free_args;
> }
Looks good to me,
Reviewed-by: Marcos Paulo de Souza <mpdesouza@suse.com>
next prev parent reply other threads:[~2020-02-21 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 13:02 [PATCH 0/3] Clean up supported flags for ioctls David Sterba
2020-02-21 13:02 ` [PATCH 1/3] btrfs: define support masks for ioctl volume args v2 David Sterba
2020-02-21 13:20 ` Marcos Paulo de Souza
2020-02-21 13:02 ` [PATCH 2/3] btrfs: use ioctl args support mask for subvolume create/delete David Sterba
2020-02-21 13:21 ` Marcos Paulo de Souza [this message]
2020-02-21 13:02 ` [PATCH 3/3] btrfs: use ioctl args support mask for device delete David Sterba
2020-02-21 13:22 ` Marcos Paulo de Souza
2020-02-21 13:24 ` [PATCH 0/3] Clean up supported flags for ioctls Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b553cc689aab3349caf2f0ba69a393127b37046.camel@suse.de \
--to=mpdesouza@suse.de \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox