From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Use IS_ALIGNED in btrfs_truncate_block instead of opencoding it
Date: Fri, 19 Jan 2018 08:45:40 +0800 [thread overview]
Message-ID: <7d7570f4-43fa-8ebc-9a16-b2777eeabf3f@gmx.com> (raw)
In-Reply-To: <1516279626-6111-1-git-send-email-nborisov@suse.com>
[-- Attachment #1.1: Type: text/plain, Size: 874 bytes --]
On 2018年01月18日 20:47, Nikolay Borisov wrote:
> No functional changes, just makes the code more readable
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> fs/btrfs/inode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 269d129ffb1f..e9690e2aba09 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -4775,8 +4775,8 @@ int btrfs_truncate_block(struct inode *inode, loff_t from, loff_t len,
> u64 block_start;
> u64 block_end;
>
> - if ((offset & (blocksize - 1)) == 0 &&
> - (!len || ((len & (blocksize - 1)) == 0)))
> + if (IS_ALIGNED(offset, blocksize) &&
> + (!len || IS_ALIGNED(len, blocksize)))
> goto out;
>
> block_start = round_down(from, blocksize);
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 520 bytes --]
next prev parent reply other threads:[~2018-01-19 0:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 12:47 [PATCH] btrfs: Use IS_ALIGNED in btrfs_truncate_block instead of opencoding it Nikolay Borisov
2018-01-19 0:45 ` Qu Wenruo [this message]
2018-01-19 23:33 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d7570f4-43fa-8ebc-9a16-b2777eeabf3f@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).