From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <wqu@suse.com>, fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] fstests: btrfs/248: test if btrfs receive can handle clone command on inodes with different NODATASUM flags
Date: Wed, 29 Sep 2021 09:45:36 +0300 [thread overview]
Message-ID: <7ee471f1-d262-dcc5-8e21-82b3cf2cffd5@suse.com> (raw)
In-Reply-To: <20210929004446.12654-1-wqu@suse.com>
On 29.09.21 г. 3:44, Qu Wenruo wrote:
> The planned fix is titled "btrfs-progs: receive: fallback to buffered
> copy if clone failed".
>
> The test case itself will create two send streams, and the 2nd stream is
> an incremental stream with a clone command in it.
>
> Using different mount options we are able to create a situation where
> clone source and destination have different NODATASUM flags, which is
> prohibited inside btrfs.
>
> The planned fix will make btrfs receive to fall back to buffered write
> to copy the data from the source file.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
If this is fixed by btrfs-progs fix shouldn't the test be part of
btrfs-progs and not the kernel test suite?
next prev parent reply other threads:[~2021-09-29 6:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 0:44 [PATCH] fstests: btrfs/248: test if btrfs receive can handle clone command on inodes with different NODATASUM flags Qu Wenruo
2021-09-29 6:45 ` Nikolay Borisov [this message]
2021-09-29 6:59 ` Qu Wenruo
2021-09-29 9:14 ` Filipe Manana
2021-09-29 9:23 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ee471f1-d262-dcc5-8e21-82b3cf2cffd5@suse.com \
--to=nborisov@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox