From: Nikolay Borisov <nborisov@suse.com>
To: Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs: drop logs when we've aborted a transaction
Date: Tue, 24 Mar 2020 17:42:18 +0200 [thread overview]
Message-ID: <82bfc910-1ab9-cae4-c6fa-dbccb515bce5@suse.com> (raw)
In-Reply-To: <54bffb37-63e4-2768-9143-521fd1bef10d@toxicpanda.com>
On 24.03.20 г. 17:10 ч., Josef Bacik wrote:
> , so now we would free the log roots once _all_ of the workers stopped.
> This is the cause of the problem, doing IO while all of our endio
> threads are stopped and gone.
>
> The fix is to make sure this gets cleaned up before we do that, which is
> handled by btrfs_error_commit_super(). Thanks,
Right, I was looking at an older branch. So with this :
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
next prev parent reply other threads:[~2020-03-24 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 14:47 [PATCH] btrfs: drop logs when we've aborted a transaction Josef Bacik
2020-03-24 14:59 ` Nikolay Borisov
2020-03-24 15:10 ` Josef Bacik
2020-03-24 15:42 ` Nikolay Borisov [this message]
2020-04-16 13:16 ` Filipe Manana
2020-04-17 17:06 ` Filipe Manana
2020-04-20 22:01 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82bfc910-1ab9-cae4-c6fa-dbccb515bce5@suse.com \
--to=nborisov@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox