From: Anand Jain <anand.jain@oracle.com>
To: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: use GFP_KERNEL in btrfs_init_dev_replace_tgtdev
Date: Fri, 16 Jun 2017 05:12:28 +0800 [thread overview]
Message-ID: <83448935-de7d-8d03-38d8-3ac64c0235b9@oracle.com> (raw)
In-Reply-To: <20170615151510.2781-1-dsterba@suse.com>
On 06/15/2017 11:15 PM, David Sterba wrote:
> The function is called from ioctl context and we don't hold any locks
> that take part in writeback. Right now it's only fs_info::volume_mutex.
yeah volume_mutex is fine.
Reviewed-by: Anand Jain <anand.jain@oracle.com>
> Signed-off-by: David Sterba <dsterba@suse.com>
> ---
> fs/btrfs/dev-replace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
> index c6cd1d599c36..f7df85509125 100644
> --- a/fs/btrfs/dev-replace.c
> +++ b/fs/btrfs/dev-replace.c
> @@ -242,7 +242,7 @@ static int btrfs_init_dev_replace_tgtdev(struct btrfs_fs_info *fs_info,
> goto error;
> }
>
> - name = rcu_string_strdup(device_path, GFP_NOFS);
> + name = rcu_string_strdup(device_path, GFP_KERNEL);
> if (!name) {
> kfree(device);
> ret = -ENOMEM;
>
prev parent reply other threads:[~2017-06-15 21:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 15:15 [PATCH] btrfs: use GFP_KERNEL in btrfs_init_dev_replace_tgtdev David Sterba
2017-06-15 21:12 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83448935-de7d-8d03-38d8-3ac64c0235b9@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).