From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 354B5C43441 for ; Mon, 19 Nov 2018 03:10:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E964D20823 for ; Mon, 19 Nov 2018 03:10:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="a9QY1sdq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E964D20823 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-btrfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727329AbeKSNca (ORCPT ); Mon, 19 Nov 2018 08:32:30 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:36171 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727503AbeKSNc3 (ORCPT ); Mon, 19 Nov 2018 08:32:29 -0500 Received: by mail-pg1-f195.google.com with SMTP id n2so5982209pgm.3 for ; Sun, 18 Nov 2018 19:10:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=K+y+YQ/aWQh6G9Pndh0g/Jo+Can1pkVpa/QQVLOmq8Y=; b=a9QY1sdqDZUiuuu1rXiWsRZDbzEgW4GZXkxeui30fQvX3vg8RBbcF8qqiDxKvBr4dA RJTZX3QX3KXmawIC8Cq2bMJGpzMpdgaPitfUN9fZPO+kZ/NpRsePUwby8x4UnogNafbU tKIgdSO7k3eWdApulbJ5Cbzrdkh3nKv71ENcNtn5sAOSoXmJ3EyrskP3mQF2mU7WowLi aWigxxk0tRpaGRqXQmbkiAuypwtpAW4BtuIZ1pzp/kf0rJlWqlF381GPpzX304O0SyPK 6pnI0WUaGk+0WukLv8K5/XZNJqrZY3ruYlfNkszYVOQ8G+PPonbzpTcjy2kqoKkkiliI ptLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=K+y+YQ/aWQh6G9Pndh0g/Jo+Can1pkVpa/QQVLOmq8Y=; b=HDj2iUE8qjKS8DIyaMHKExPVfRioI9Gjk6ihtc6VgJgfzVMIcix4SB7ZJRPz/CZ+x3 7PPigswCP+mr0AdOg2qP0Y6kcA5Rqz/JWSwoiotyS/qyM4jY/x1Oagd4tRDtl0OdrVf3 zVnqg+gW5Kan0sMRgANvyx6XcTgl1hOWHEFZDh5xTfkjOqGnjEkgGOfPK/cGA4yUKQtZ Ix67b4oMmClTanhheNVOflQZP/Ncawg5OghpVTi2lxRimpFWdj6Fbg43YfUu7LqhTP6D 0yU23NaKHhiubNk34AROjCYpOQeL+UuAimHK673XW4GRLfc5IpiLBWUiwCuCfJbdZ6w4 0B5g== X-Gm-Message-State: AGRZ1gKON62VCmugE5tqHweGBZLP+4UnYX6Uw6vdmXkTSBRAC862lLXR IE/KPa/0safS2iJFK2lSi53W8g== X-Google-Smtp-Source: AJdET5cTwQDcMN5//RJsS90xfsg40HWnovwuyPpZPwFZoVBwVqijvq9qBcNHKZj8vZSpLu4TZ2phAQ== X-Received: by 2002:a63:e4d:: with SMTP id 13mr17304659pgo.369.1542597018284; Sun, 18 Nov 2018 19:10:18 -0800 (PST) Received: from [192.168.1.121] (66.29.188.166.static.utbb.net. [66.29.188.166]) by smtp.gmail.com with ESMTPSA id b5sm22212402pfc.150.2018.11.18.19.10.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Nov 2018 19:10:17 -0800 (PST) Subject: Re: [PATCH V10 01/19] block: introduce multi-page page bvec helpers To: Ming Lei , Christoph Hellwig Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, Shaohua Li , linux-raid@vger.kernel.org, linux-erofs@lists.ozlabs.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , Theodore Ts'o , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com References: <20181115085306.9910-1-ming.lei@redhat.com> <20181115085306.9910-2-ming.lei@redhat.com> <20181116131305.GA3165@lst.de> <20181119022327.GC10838@ming.t460p> From: Jens Axboe Message-ID: <83fb4102-bffe-41f1-c8d0-3bdf61fe0ba8@kernel.dk> Date: Sun, 18 Nov 2018 20:10:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181119022327.GC10838@ming.t460p> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 11/18/18 7:23 PM, Ming Lei wrote: > On Fri, Nov 16, 2018 at 02:13:05PM +0100, Christoph Hellwig wrote: >>> -#define bvec_iter_page(bvec, iter) \ >>> +#define mp_bvec_iter_page(bvec, iter) \ >>> (__bvec_iter_bvec((bvec), (iter))->bv_page) >>> >>> -#define bvec_iter_len(bvec, iter) \ >>> +#define mp_bvec_iter_len(bvec, iter) \ >> >> I'd much prefer if we would stick to the segment naming that >> we also use in the higher level helper. >> >> So segment_iter_page, segment_iter_len, etc. > > We discussed the naming problem before, one big problem is that the 'segment' > in bio_for_each_segment*() means one single page segment actually. > > If we use segment_iter_page() here for multi-page segment, it may > confuse people. > > Of course, I prefer to the naming of segment/page, > > And Jens didn't agree to rename bio_for_each_segment*() before. I didn't like frivolous renaming (and I still don't), but mp_ is horrible imho. Don't name these after the fact that they are done in conjunction with supporting multipage bvecs. That very fact will be irrelevant very soon -- Jens Axboe