From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH 14/15] btrfs: handle errors from btrfs_dec_ref properly
Date: Fri, 19 Apr 2024 14:17:09 -0400 [thread overview]
Message-ID: <85733fb309238393fbfb60dd4c2d88ca3becbc37.1713550368.git.josef@toxicpanda.com> (raw)
In-Reply-To: <cover.1713550368.git.josef@toxicpanda.com>
In walk_up_proc() we BUG_ON(ret) from btrfs_dec_ref(). This is
incorrect, we have proper error handling here, return the error.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
fs/btrfs/extent-tree.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index d3d2f61b7363..0f59339aac5d 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -5808,7 +5808,10 @@ static noinline int walk_up_proc(struct btrfs_trans_handle *trans,
ret = btrfs_dec_ref(trans, root, eb, 1);
else
ret = btrfs_dec_ref(trans, root, eb, 0);
- BUG_ON(ret); /* -ENOMEM */
+ if (ret) {
+ btrfs_abort_transaction(trans, ret);
+ return ret;
+ }
if (is_fstree(btrfs_root_id(root))) {
ret = btrfs_qgroup_trace_leaf_items(trans, eb);
if (ret) {
--
2.43.0
next prev parent reply other threads:[~2024-04-19 18:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 18:16 [PATCH 00/15] btrfs: snapshot delete cleanups Josef Bacik
2024-04-19 18:16 ` [PATCH 01/15] btrfs: don't do find_extent_buffer in do_walk_down Josef Bacik
2024-04-23 21:55 ` Qu Wenruo
2024-04-19 18:16 ` [PATCH 02/15] btrfs: push ->owner_root check into btrfs_read_extent_buffer Josef Bacik
2024-04-23 22:09 ` Qu Wenruo
2024-04-19 18:16 ` [PATCH 03/15] btrfs: use btrfs_read_extent_buffer in do_walk_down Josef Bacik
2024-04-19 18:16 ` [PATCH 04/15] btrfs: push lookup_info into walk_control Josef Bacik
2024-04-19 18:17 ` [PATCH 05/15] btrfs: move the eb uptodate code into it's own helper Josef Bacik
2024-04-19 18:17 ` [PATCH 06/15] btrfs: remove need_account in do_walk_down Josef Bacik
2024-04-19 18:17 ` [PATCH 07/15] btrfs: unify logic to decide if we need to walk down into a node Josef Bacik
2024-04-19 18:17 ` [PATCH 08/15] btrfs: extract the reference dropping code into it's own helper Josef Bacik
2024-04-19 18:17 ` [PATCH 09/15] btrfs: don't BUG_ON ENOMEM in walk_down_proc Josef Bacik
2024-04-19 18:17 ` [PATCH 10/15] btrfs: handle errors from ref mods during UPDATE_BACKREF Josef Bacik
2024-04-19 18:17 ` [PATCH 11/15] btrfs: replace BUG_ON with ASSERT in walk_down_proc Josef Bacik
2024-04-19 18:17 ` [PATCH 12/15] btrfs: clean up our handling of refs == 0 in snapshot delete Josef Bacik
2024-04-24 12:23 ` David Sterba
2024-04-19 18:17 ` [PATCH 13/15] btrfs: convert correctness BUG_ON()'s to ASSERT()'s in walk_up_proc Josef Bacik
2024-04-19 18:17 ` Josef Bacik [this message]
2024-04-19 18:17 ` [PATCH 15/15] btrfs: add documentation around snapshot delete Josef Bacik
2024-04-24 12:31 ` [PATCH 00/15] btrfs: snapshot delete cleanups David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85733fb309238393fbfb60dd4c2d88ca3becbc37.1713550368.git.josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox