Re: [PATCH] fstests: btrfs: test setting compression via xattr on nodatacow files

Chung-Chiang Cheng
2022-04-22T11:11:59Z

Hi Filipe,

> > +_require_scratch
> > +_require_chattr C
> > +_require_chattr c
>
> This require, for chattr c, is not needed, since the test never calls
> chattr with +c or -c.
>
> It also misses a call to:
>
> _require_attrs
>
> Due to the calls to setfattr and lsattr.

Thanks for your notification. I'll fix these issues.

> root 15:43:50 /home/fdmanana/git/hub/xfstests (master)> diff -u /home/fdmanana/git/hub/xfstests/tests/btrfs/264.out /home/fdmanana/git/hub/xfstests/results//btrfs/264.out.bad
> --- /home/fdmanana/git/hub/xfstests/tests/btrfs/264.out 2022-04-19 14:49:03.845696283 +0100
> +++ /home/fdmanana/git/hub/xfstests/results//btrfs/264.out.bad 2022-04-19 15:43:50.413816742 +0100
> @@ -1,9 +1,9 @@
> QA output created by 264
> SCRATCH_MNT/foo ---
> SCRATCH_MNT/foo Compression_Requested
> -SCRATCH_MNT/foo ---
> +SCRATCH_MNT/foo Dont_Compress
> SCRATCH_MNT/foo Compression_Requested
> -SCRATCH_MNT/foo ---
> +SCRATCH_MNT/foo Dont_Compress
> SCRATCH_MNT/foo Compression_Requested
> SCRATCH_MNT/bar No_COW
> setfattr: SCRATCH_MNT/bar: Invalid argument
> root 15:43:52 /home/fdmanana/git/hub/xfstests (master)>
>
> So the test needs to be updated and tested on a recent kernel.
> Other than that, it looks fine to me.

I can see why my output is different from yours. I tested this item with
the latest upstream kernel, but my `chattr` comes from e2fsprogs-1.45.5,
which does not yet support Dont_Compress. This test relies on a recent
chattr, but `_require_attrs` does not check its version. In any case, I
will send a v2 patch based on the latest chattr.

Thanks.