Re: [btrfs-progs PATCH 1/4] tests: common: Add check_dm_target_support helper

Marcos Paulo de Souza
2019-12-18T16:03:14Z

On Wed, 2019-12-18 at 16:58 +0100, David Sterba wrote:
> On Wed, Dec 18, 2019 at 08:26:09AM +0800, Qu Wenruo wrote:
> > > +# check if the targets passed as arguments are available, and if
> not just skip
> > > +# the test
> > > +check_dm_target_support()
> > > +{
> > > + for target in "$@"; do
> > > + $SUDO_HELPER modprobe dm-$target >/dev/null 2>&1
> >
> > To utilize $SUDO_HELPER, we need to call setup_root_helper() in the
> > first place, just like all the other $SUDO_HELPER users in
> `tests/common`.
> >
> > Although nowadays it feels a little unnecessary, since the
> functionality
> > is introduced because I'm a lazybone who doesn't bother to startup
> a VM
> > to do proper test, but uses current unprivileged user to utilize
> self tests.
> >
> > Maybe it's time to get rid of SUDO_HELPER ?
>
> No, that should stay, my local testing relies on that heavily.

An updated version keeping SUDO_HELPER and adding setup_root_helper is
in [1].

All other patches are the same ones, already reviewed by Qu.

[1]: https://github.com/marcosps/btrfs-progs/tree/mpdesouza_mkfs_fixes