From: Anand Jain <anand.jain@oracle.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] btrfs: add proper subpage compress read support
Date: Thu, 4 Feb 2021 20:17:16 +0800 [thread overview]
Message-ID: <87318176-f5f5-c20a-ce63-290f9f84065c@oracle.com> (raw)
In-Reply-To: <20210204070324.45703-1-wqu@suse.com>
Nice. Works well.
Thanks, Anand
On 2/4/2021 3:03 PM, Qu Wenruo wrote:
> During the long time subpage development, I forgot to properly check
> compression code after just one compression read success during early
> development.
>
> It turns out that, with current RO support, the compression read needs
> more modification to make it work.
>
> Thankfully, the patchset is small, and should not cause problems for
> regular sectorsize == PAGE_SIZE case.
>
> Thanks Anand for exposing the problems.
>
> Qu Wenruo (2):
> btrfs: make btrfs_submit_compressed_read() to be subpage compatible
> btrfs: make check_compressed_csum() to be subpage compatible
>
> fs/btrfs/compression.c | 67 ++++++++++++++++++++++++++++++------------
> 1 file changed, 48 insertions(+), 19 deletions(-)
>
next prev parent reply other threads:[~2021-02-04 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 7:03 [PATCH 0/2] btrfs: add proper subpage compress read support Qu Wenruo
2021-02-04 7:03 ` [PATCH 1/2] btrfs: make btrfs_submit_compressed_read() to be subpage compatible Qu Wenruo
2021-02-04 7:03 ` [PATCH 2/2] btrfs: make check_compressed_csum() " Qu Wenruo
2021-02-04 12:17 ` Anand Jain [this message]
2021-02-10 22:21 ` [PATCH 0/2] btrfs: add proper subpage compress read support David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87318176-f5f5-c20a-ce63-290f9f84065c@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).