From: Andi Kleen <andi@firstfloor.org>
To: Diego Calleja <diegocg@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Fix possible pointer dereference
Date: Wed, 07 Oct 2009 02:03:42 +0200 [thread overview]
Message-ID: <873a5w134x.fsf@basil.nowhere.org> (raw)
In-Reply-To: <200910062215.22562.diegocg@gmail.com> (Diego Calleja's message of "Tue, 6 Oct 2009 22:15:22 +0200")
Diego Calleja <diegocg@gmail.com> writes:
> We should always check btrfs_alloc_path(). Some places BUG(),
> others return -ENOMEM, btrfs_insert_dir_item() seems like it can return
> safely.
The problem is that all the callers don't handle errors.
It doesn't make sense to fix it low-level currently when it cannot be handled
properly higher up anyways.
Proper out of memory handling needs much more work, one liners
don't really help.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
prev parent reply other threads:[~2009-10-07 0:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 20:15 [PATCH] Fix possible pointer dereference Diego Calleja
2009-10-07 0:03 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873a5w134x.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=diegocg@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox