Re: [PATCH v2] btrfs/122: fix nodesize option in mfks.btrfs

[Ritesh Harjani (IBM) <ritesh.list@gmail.com>]

Anand Jain <anand.jain@oracle.com> writes:

> btrf/122 is failing on a system with 64k page size:
>
>      QA output created by 122
>     +ERROR: illegal nodesize 16384 (smaller than 65536)
>     +mount: /mnt/scratch: wrong fs type, bad option, bad superblock on /dev/vdb2, missing codepage or helper program, or other error.
>     +mount /dev/vdb2 /mnt/scratch failed
>     +(see /xfstests-dev/results//btrfs/122.full for details)
>
> Mkfs.btrfs sets the default node size to 16K when the sector size is less
> than 16K, and it matches the sector size when it's greater than 16K.
> So, there's no need to explicitly set it.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> v2: Remove the redundant explicit nodesize option from mkfs.btrfs.
>     Changed: Title from "btrfs/122: adjust nodesize to match pagesize"
>
>
>  tests/btrfs/122 | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Thanks for fixing this. I have tested this on Power with 64k pagesize and x86
with 4k pagesize.

Please feel free to add -
Tested-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

-ritesh