From: Daniel Axtens <dja@axtens.net>
To: The development of GNU GRUB <grub-devel@gnu.org>,
Grub-devel@gnu.org,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Cc: Qu Wenruo <wqu@suse.com>
Subject: Re: About the code style requirement
Date: Wed, 29 Sep 2021 16:10:04 +1000 [thread overview]
Message-ID: <87ee976hfn.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <d7af6d9d-7178-f950-1934-3179e001e291@suse.com>
Qu Wenruo via Grub-devel <grub-devel@gnu.org> writes:
> Hi,
>
> I'm recently considering to cross-port btrfs-progs/U-boot btrfs code to
> GRUB, so that we can have more unified code base, with more features
> (and of-course bug fixes)
>
> But the first blockage I'm hitting is the code style.
>
> It looks like GRUB is using its own code style which is not found in
> kernel/btrfs-progs/U-boot.
>
> But I didn't find where the code style doc is, so is it a hard
> requirement to follow the existing style even we're cross-porting most
> code unmodified from other projects?
It's largely based on the GNU coding style. The `indent` program can do
most of the work for you.
Certain parts of grub that are imported more-or-less unmodified do
follow their own style, e.g. grub-core/lib/json/jsmn.h
I'm not a maintainer so I can't tell you how hard the style requirement
is.
Kind regards,
Daniel
> Thanks,
> Qu
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
next prev parent reply other threads:[~2021-09-29 6:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 5:41 About the code style requirement Qu Wenruo
2021-09-29 6:10 ` Daniel Axtens [this message]
2021-09-30 5:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee976hfn.fsf@dja-thinkpad.axtens.net \
--to=dja@axtens.net \
--cc=grub-devel@gnu.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox