* About the code style requirement
@ 2021-09-29 5:41 Qu Wenruo
2021-09-29 6:10 ` Daniel Axtens
2021-09-30 5:33 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Qu Wenruo @ 2021-09-29 5:41 UTC (permalink / raw)
To: Grub-devel, linux-btrfs@vger.kernel.org
Hi,
I'm recently considering to cross-port btrfs-progs/U-boot btrfs code to
GRUB, so that we can have more unified code base, with more features
(and of-course bug fixes)
But the first blockage I'm hitting is the code style.
It looks like GRUB is using its own code style which is not found in
kernel/btrfs-progs/U-boot.
But I didn't find where the code style doc is, so is it a hard
requirement to follow the existing style even we're cross-porting most
code unmodified from other projects?
Thanks,
Qu
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: About the code style requirement
2021-09-29 5:41 About the code style requirement Qu Wenruo
@ 2021-09-29 6:10 ` Daniel Axtens
2021-09-30 5:33 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Axtens @ 2021-09-29 6:10 UTC (permalink / raw)
To: The development of GNU GRUB, Grub-devel,
linux-btrfs@vger.kernel.org
Cc: Qu Wenruo
Qu Wenruo via Grub-devel <grub-devel@gnu.org> writes:
> Hi,
>
> I'm recently considering to cross-port btrfs-progs/U-boot btrfs code to
> GRUB, so that we can have more unified code base, with more features
> (and of-course bug fixes)
>
> But the first blockage I'm hitting is the code style.
>
> It looks like GRUB is using its own code style which is not found in
> kernel/btrfs-progs/U-boot.
>
> But I didn't find where the code style doc is, so is it a hard
> requirement to follow the existing style even we're cross-porting most
> code unmodified from other projects?
It's largely based on the GNU coding style. The `indent` program can do
most of the work for you.
Certain parts of grub that are imported more-or-less unmodified do
follow their own style, e.g. grub-core/lib/json/jsmn.h
I'm not a maintainer so I can't tell you how hard the style requirement
is.
Kind regards,
Daniel
> Thanks,
> Qu
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: About the code style requirement
2021-09-29 5:41 About the code style requirement Qu Wenruo
2021-09-29 6:10 ` Daniel Axtens
@ 2021-09-30 5:33 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2021-09-30 5:33 UTC (permalink / raw)
To: Qu Wenruo; +Cc: Grub-devel, linux-btrfs@vger.kernel.org
On Wed, Sep 29, 2021 at 01:41:09PM +0800, Qu Wenruo wrote:
> Hi,
>
> I'm recently considering to cross-port btrfs-progs/U-boot btrfs code to
> GRUB, so that we can have more unified code base, with more features (and
> of-course bug fixes)
The GPLv2 only kernel code is not going be much use for the GPLv3+ grub
code.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-30 5:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-29 5:41 About the code style requirement Qu Wenruo
2021-09-29 6:10 ` Daniel Axtens
2021-09-30 5:33 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox