public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicholas D Steeves <sten@debian.org>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>,
	Brett Dikeman <brett.dikeman@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: corrupt leaf, invalid data ref objectid value, read time tree block corruption detected Inbox
Date: Fri, 29 Nov 2024 20:11:05 -0500	[thread overview]
Message-ID: <87h67pmspi.fsf@digitalmercury.freeddns.org> (raw)
In-Reply-To: <cfc9177b-ab53-40c2-b627-0045e9348938@gmx.com>

[-- Attachment #1: Type: text/plain, Size: 2224 bytes --]

Qu Wenruo <quwenruo.btrfs@gmx.com> writes:

> 在 2024/11/27 09:39, Brett Dikeman 写道:
>> On Tue, Nov 26, 2024 at 4:30 PM Qu Wenruo <quwenruo.btrfs@gmx.com> wrote:
>>
>>> Inode cache is what you need to clear.
>>
>> Brilliant! Thank you, Qu. It did mount cleanly. Shame Debian's
>> toolchain is so out-of-date. I pinged the maintainer asking if they
>> could pull 6.11.
>>
>> Is there anything I could have done that would have caused the
>> corrupted inode cache?
>
> It's not corrupted, but us deprecating that feature quite some time ago.
> And then a recently enhanced sanity check just treat such long
> deprecated feature as an error, thus rejecting those tree blocks.
>
>>
>> 'btrfs check' thought the second drive was busy after unmounting, but
>> a reboot cured that.
>>
>> check found the following; Is the fix for this to clear the free space cache?
>
> I'd recommend to go v2 cache directly.
>
> You may not want to hear, but we're going to deprecate v1 cache too.
>
> V2 cache has way better crash handling, I have not yet seen a corrupted
> v2 cache yet.

Let's avoid a "btrfs is the only fs that ate my data" storm.  Would it
be sufficient to provide free space cache v2 migration instructions in
our release notes?  If not, would you be willing to write something?
Alternatively, should this be automatic, and in-kernel?  Debian users
tend to have long-running installations and don't tend to reinstall.  I
think you'll agree we ought to get ahead of the thousands of users who
have v1 cache and who ran mkfs with btrfs-progs as early as 4.4 or 4.9.

Most users will migrate from a recent 6.1.x (close to kernel.org's)
directly to 6.12.x (what seems to be the most likely LTS).  Many have
also tracked the stable mainline or have recently upgraded to 6.11.

Beyond that, I'm not aware of any format chances (other than some new
experimental raid56 stuff), but it might also be nice to know if there's
a threshold where it would be better to reformat an "aged" filesystem.


Kind regards,
Nicholas

P.S. We'll fix the ancient btrfs-progs problem before the new year.  The
current issue is where "strong package ownership" processes slow things
down.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

  reply	other threads:[~2024-11-30  1:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-26 16:11 corrupt leaf, invalid data ref objectid value, read time tree block corruption detected Inbox Brett Dikeman
2024-11-26 21:30 ` Qu Wenruo
2024-11-26 23:09   ` Brett Dikeman
2024-11-27  3:17     ` Qu Wenruo
2024-11-30  1:11       ` Nicholas D Steeves [this message]
2024-11-30  4:37         ` Qu Wenruo
2024-12-27 22:25       ` Nicholas D Steeves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h67pmspi.fsf@digitalmercury.freeddns.org \
    --to=sten@debian.org \
    --cc=brett.dikeman@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox