From: Satoru Takeuchi <satoru.takeuchi@gmail.com>
To: dsterba@suse.cz, Satoru Takeuchi <satoru.takeuchi@gmail.com>,
Mike Fleetwood <mike.fleetwood@googlemail.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2] btrfs-progs: allow "none" to disable compression for convenience
Date: Sun, 15 Oct 2017 08:35:47 +0900 [thread overview]
Message-ID: <87shel9ub0.wl-satoru.takeuchi@gmail.com> (raw)
In-Reply-To: <20170919151427.GH29043@twin.jikos.cz>
At Tue, 19 Sep 2017 17:14:27 +0200,
David Sterba wrote:
>
> On Mon, Sep 18, 2017 at 09:41:17AM +0900, Satoru Takeuchi wrote:
> > At Sun, 17 Sep 2017 14:08:40 +0100,
> > Mike Fleetwood wrote:
> > >
> > > On 17 September 2017 at 01:36, Satoru Takeuchi
> > > <satoru.takeuchi@gmail.com> wrote:
> > > > It's messy to use "" to disable compression. Introduce the new value "no"
> > > > which can also be used for this purpose.
> > >
> > > From an English language point of view, "none" would be better. None
> > > says the absence of, where as no is more general negative.
> >
> > Thank you for your comment. How about is it?
> >
> > ---
> > It's messy to use "" to disable compression. Introduce the new value "none"
> > which can also be used for this purpose.
>
> I'd allow both values, 'no' and 'none', similar to the mount options,
> that also accept both (technically, the 'no' + anything is accepted for
> disabling compression).
But only "no" is writtein in man 5 btrfs.
prev parent reply other threads:[~2017-10-14 23:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-17 0:36 [PATCH] btrfs-progs: allow "no" to disable compression for convenience Satoru Takeuchi
2017-09-17 13:08 ` Mike Fleetwood
2017-09-18 0:41 ` [PATCH v2] btrfs-progs: allow "none" " Satoru Takeuchi
2017-09-19 15:14 ` David Sterba
2017-09-20 2:03 ` Satoru Takeuchi
2017-10-14 23:35 ` Satoru Takeuchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shel9ub0.wl-satoru.takeuchi@gmail.com \
--to=satoru.takeuchi@gmail.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=mike.fleetwood@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).